You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/30 18:59:21 UTC

[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3600: Core: Handle metrics-based deletes

aokolnychyi commented on a change in pull request #3600:
URL: https://github.com/apache/iceberg/pull/3600#discussion_r759574930



##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -170,16 +172,13 @@ void delete(CharSequence path) {
       return ImmutableList.of();
     }
 
-    // use a common metrics evaluator for all manifests because it is bound to the table schema
-    StrictMetricsEvaluator metricsEvaluator = new StrictMetricsEvaluator(tableSchema, deleteExpression);

Review comment:
       I can no longer use one metrics evaluator so I switched to one per manifest with some caching. I can introduce more caching per spec to avoid creating one expression evaluator per manifest but it will probably complicate things a little. Let me know what everybody thinks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org