You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/05 16:01:37 UTC
[GitHub] [superset] geido opened a new pull request #16092: fix: Adjust width of cell in Table
geido opened a new pull request #16092:
URL: https://github.com/apache/superset/pull/16092
### SUMMARY
It adjusts the width of the cell in the Table to be just enough to show the full chart.
Fixes #15957
### BEFORE
### AFTER
### TESTING INSTRUCTIONS
1. Open a Time-Series Table chart in Explore
2. Configure the Time Series Columns with type Sparkline
3. Run the query
4. Make sure the chart is appearing fully and no numbers are cut
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #15957
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] removed a comment on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893669915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-895316696
# [Codecov](https://codecov.io/gh/apache/superset/pull/16092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16092](https://codecov.io/gh/apache/superset/pull/16092?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0bdb4e) into [master](https://codecov.io/gh/apache/superset/commit/ddb500590072ede3349a2a85a5d28a7953e21e32?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddb5005) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head f0bdb4e differs from pull request most recent head 4f7a0c5. Consider uploading reports for the commit 4f7a0c5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16092 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 995 995
Lines 52884 52884
Branches 6721 6721
=======================================
Hits 40636 40636
Misses 12023 12023
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.23% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16092/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16092?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16092?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ddb5005...4f7a0c5](https://codecov.io/gh/apache/superset/pull/16092?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893668949
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
geido merged pull request #16092:
URL: https://github.com/apache/superset/pull/16092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893669915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893764194
LGTM! Thanks for the fix!
https://user-images.githubusercontent.com/67837651/128414433-f87fe5b3-0377-4e95-abe0-8fa95d89b698.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893722021
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893722021
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893722579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893764194
LGTM! Thanks for the fix!
https://user-images.githubusercontent.com/67837651/128414490-27ef79a4-5958-4c4b-b823-5b68beb6f1d3.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina removed a comment on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
michael-s-molina removed a comment on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-893668949
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu commented on pull request #16092: fix(Explore): Adjust width of cell in Time-Series Table chart
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu commented on pull request #16092:
URL: https://github.com/apache/superset/pull/16092#issuecomment-895537368
🏷 2021.31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org