You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ba...@apache.org on 2009/11/18 07:43:24 UTC

svn commit: r881685 - in /commons/proper/lang/trunk/src: java/org/apache/commons/lang/ArrayUtils.java test/org/apache/commons/lang/ArrayUtilsTest.java

Author: bayard
Date: Wed Nov 18 06:43:23 2009
New Revision: 881685

URL: http://svn.apache.org/viewvc?rev=881685&view=rev
Log:
Removing ArrayUtils.hashCode per LANG-492; it is now available as java.util.Arrays.hashCode

Modified:
    commons/proper/lang/trunk/src/java/org/apache/commons/lang/ArrayUtils.java
    commons/proper/lang/trunk/src/test/org/apache/commons/lang/ArrayUtilsTest.java

Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/ArrayUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ArrayUtils.java?rev=881685&r1=881684&r2=881685&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/java/org/apache/commons/lang/ArrayUtils.java (original)
+++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/ArrayUtils.java Wed Nov 18 06:43:23 2009
@@ -181,18 +181,6 @@
     }
 
     /**
-     * <p>Get a hashCode for an array handling multi-dimensional arrays correctly.</p>
-     *
-     * <p>Multi-dimensional primitive arrays are also handled correctly by this method.</p>
-     *
-     * @param array  the array to get a hashCode for, may be <code>null</code>
-     * @return a hashCode for the array, zero if null array input
-     */
-    public static int hashCode(Object array) {
-        return new HashCodeBuilder().append(array).toHashCode();
-    }
-
-    /**
      * <p>Compares two arrays, using equals(), handling multi-dimensional arrays
      * correctly.</p>
      *

Modified: commons/proper/lang/trunk/src/test/org/apache/commons/lang/ArrayUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/org/apache/commons/lang/ArrayUtilsTest.java?rev=881685&r1=881684&r2=881685&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/org/apache/commons/lang/ArrayUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/org/apache/commons/lang/ArrayUtilsTest.java Wed Nov 18 06:43:23 2009
@@ -93,19 +93,6 @@
     }
 
     //-----------------------------------------------------------------------
-    public void testHashCode() {
-        long[][] array1 = new long[][] {{2,5}, {4,5}};
-        long[][] array2 = new long[][] {{2,5}, {4,6}};
-        assertEquals(true, ArrayUtils.hashCode(array1) == ArrayUtils.hashCode(array1));
-        assertEquals(false, ArrayUtils.hashCode(array1) == ArrayUtils.hashCode(array2));
-        
-        Object[] array3 = new Object[] {new String(new char[] {'A', 'B'})};
-        Object[] array4 = new Object[] {"AB"};
-        assertEquals(true, ArrayUtils.hashCode(array3) == ArrayUtils.hashCode(array3));
-        assertEquals(true, ArrayUtils.hashCode(array3) == ArrayUtils.hashCode(array4));
-    }
-
-    //-----------------------------------------------------------------------
     private void assertIsEquals(Object array1, Object array2, Object array3) {
         assertEquals(true, ArrayUtils.isEquals(array1, array1));
         assertEquals(true, ArrayUtils.isEquals(array2, array2));