You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/12 11:18:42 UTC

[GitHub] [rocketmq] RapperCL opened a new pull request, #5295: [ISSUE #5294]fix ClassLoad path optimization

RapperCL opened a new pull request, #5295:
URL: https://github.com/apache/rocketmq/pull/5295

   [issue](https://github.com/apache/rocketmq/issues/5294)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #5295:
URL: https://github.com/apache/rocketmq/pull/5295#issuecomment-1305114434

   @RapperCL Your pull request looks good. Unfortunately, it now has conflicts with develop branch.... Can you please rebase it on top of `develop` branch so that it can pass all CI checks?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5295:
URL: https://github.com/apache/rocketmq/pull/5295#issuecomment-1278745415

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5295?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#5295](https://codecov.io/gh/apache/rocketmq/pull/5295?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36e5d24) into [develop](https://codecov.io/gh/apache/rocketmq/commit/8d10c9601d137be397d17003634cceb89c949a69?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d10c96) will **decrease** coverage by `0.10%`.
   > The diff coverage is `11.76%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #5295      +/-   ##
   =============================================
   - Coverage      43.20%   43.09%   -0.11%     
   + Complexity      7807     7804       -3     
   =============================================
     Files            998     1001       +3     
     Lines          69451    69646     +195     
     Branches        9169     9199      +30     
   =============================================
   + Hits           30003    30016      +13     
   - Misses         35682    35859     +177     
   - Partials        3766     3771       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../apache/rocketmq/common/utils/ServiceProvider.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvU2VydmljZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../apache/rocketmq/proxy/grpc/GrpcServerBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvR3JwY1NlcnZlckJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `43.54% <12.50%> (-0.13%)` | :arrow_down: |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `53.66% <100.00%> (ø)` | |
   | [...etmq/proxy/grpc/v2/channel/GrpcChannelManager.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvY2hhbm5lbC9HcnBjQ2hhbm5lbE1hbmFnZXIuamF2YQ==) | `26.82% <0.00%> (-10.21%)` | :arrow_down: |
   | [...org/apache/rocketmq/proxy/common/ProxyContext.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbW1vbi9Qcm94eUNvbnRleHQuamF2YQ==) | `84.84% <0.00%> (-8.49%)` | :arrow_down: |
   | [...ocketmq/proxy/service/route/TopicRouteService.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2Uvcm91dGUvVG9waWNSb3V0ZVNlcnZpY2UuamF2YQ==) | `60.71% <0.00%> (-4.68%)` | :arrow_down: |
   | [...ocketmq/proxy/common/AbstractStartAndShutdown.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbW1vbi9BYnN0cmFjdFN0YXJ0QW5kU2h1dGRvd24uamF2YQ==) | `23.07% <0.00%> (-4.20%)` | :arrow_down: |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `49.23% <0.00%> (-3.08%)` | :arrow_down: |
   | [...apache/rocketmq/broker/client/ConsumerManager.java](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0NvbnN1bWVyTWFuYWdlci5qYXZh) | `77.23% <0.00%> (-2.60%)` | :arrow_down: |
   | ... and [49 more](https://codecov.io/gh/apache/rocketmq/pull/5295/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RapperCL closed pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

Posted by GitBox <gi...@apache.org>.
RapperCL closed pull request #5295: [ISSUE #5294]fix ClassLoad path optimization 
URL: https://github.com/apache/rocketmq/pull/5295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #5295:
URL: https://github.com/apache/rocketmq/pull/5295#discussion_r994008382


##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -894,15 +894,19 @@ public boolean executeSendMessageBack(List<MessageExt> msgList, String brokerNam
     }
 
     private void initialTransaction() {
-        this.transactionalMessageService = ServiceProvider.loadClass(ServiceProvider.TRANSACTION_SERVICE_ID, TransactionalMessageService.class);

Review Comment:
   IMO,The point of this is to effectively use the SPI mechanism so that users can extend their own implementation, so load this path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #5295:
URL: https://github.com/apache/rocketmq/pull/5295#discussion_r994008382


##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -894,15 +894,19 @@ public boolean executeSendMessageBack(List<MessageExt> msgList, String brokerNam
     }
 
     private void initialTransaction() {
-        this.transactionalMessageService = ServiceProvider.loadClass(ServiceProvider.TRANSACTION_SERVICE_ID, TransactionalMessageService.class);

Review Comment:
   IMO,The point of this is to effectively use the SPI mechanism so that users can extend their own implementation, so load this path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui merged pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #5295:
URL: https://github.com/apache/rocketmq/pull/5295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org