You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/22 15:32:28 UTC
[GitHub] [airflow] turbaszek opened a new pull request #12549: Fix sed command on MacOS
turbaszek opened a new pull request #12549:
URL: https://github.com/apache/airflow/pull/12549
Fixes the following error on MacOS:
```
+ sed 's/version =.*$/version = '\''2.0.0b3'\''/' -i.out -e /Users/turbaszek/code/airflow/setup.py
sed: -i.out: No such file or directory
sed: -e: No such file or directory
```
based on:
https://github.com/kedacore/keda/pull/1071/files
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12549: Fix sed command on MacOS
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12549:
URL: https://github.com/apache/airflow/pull/12549#discussion_r529443445
##########
File path: scripts/ci/pre_commit/pre_commit_sync_version.sh
##########
@@ -25,4 +25,5 @@ set -x
AIRFLOW_VERSION_STRING=$(grep "version =" "${AIRFLOW_SOURCES}/airflow/version.py")
readonly AIRFLOW_VERSION_STRING
-sed "s/version =.*$/${AIRFLOW_VERSION_STRING}/" -i "${AIRFLOW_SOURCES}/setup.py"
+sed -i".out" -e "s/version =.*$/${AIRFLOW_VERSION_STRING}/" "${AIRFLOW_SOURCES}/setup.py"
Review comment:
I think this could be `sed -i''`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12549: Fix sed command on MacOS
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12549:
URL: https://github.com/apache/airflow/pull/12549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org