[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8867: [WIP] Customize schema name for the CTA queries

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #8867: [WIP] Customize schema name for the CTA queries
URL: https://github.com/apache/incubator-superset/pull/8867#discussion_r360615292
 
 

 ##########
 File path: superset/sql_lab.py
 ##########
 @@ -366,6 +368,11 @@ def execute_sql_statements(
                     payload = handle_query_error(msg, query, session, payload)
                     return payload
 
+        # Commit the connection so CTA queries will create the table.
+        # TODO(bk): consider if it's only needed for postgres.
+        if conn:
 
 Review comment:
   When would `conn` be falsy?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org