[jira] [Commented] (PHOENIX-2144) Implement JSON operators

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641866#comment-14641866 ] 

ASF GitHub Bot commented on PHOENIX-2144:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/101#discussion_r35489860
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java ---
    @@ -200,12 +224,12 @@ public Expression visitLeave(ComparisonParseNode node, List<Expression> children
             Expression lhsExpr = children.get(0);
             Expression rhsExpr = children.get(1);
             PDataType dataTypeOfLHSExpr = lhsExpr.getDataType();
    -        if (dataTypeOfLHSExpr != null && !dataTypeOfLHSExpr.isEqualitySupported()) {
    +        if (!(lhsExpr instanceof BaseJSONExpression)&& dataTypeOfLHSExpr != null && !dataTypeOfLHSExpr.isEqualitySupported()) {
    --- End diff --
    
    The visitLeave(ComparisonParseNode) method gets called when =, <, >, etc. comparison operators are used in an expression. I thought this wasn't valid for JSON?


> Implement JSON operators 
> -------------------------
>
>                 Key: PHOENIX-2144
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2144
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Thomas D'Silva
>             Fix For: 5.0.0, 4.4.1
>
>
> See http://www.postgresql.org/docs/9.4/static/functions-json.html 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)