You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by ant elder <an...@gmail.com> on 2010/04/22 09:18:34 UTC
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
On Thu, Apr 22, 2010 at 5:46 AM, <lr...@apache.org> wrote:
> Author: lresende
> Date: Thu Apr 22 04:46:56 2010
> New Revision: 936611
>
> URL: http://svn.apache.org/viewvc?rev=936611&view=rev
> Log:
> Changing stripes dependency scope to properly generate OSGi 'bundle' and avoid issues with stripes module manifest
>
> Modified:
> tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
>
> Modified: tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
> URL: http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml?rev=936611&r1=936610&r2=936611&view=diff
> ==============================================================================
> --- tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml (original)
> +++ tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml Thu Apr 22 04:46:56 2010
> @@ -46,7 +46,6 @@
> <groupId>net.sourceforge.stripes</groupId>
> <artifactId>stripes</artifactId>
> <version>1.5.2</version>
> - <scope>provided</scope>
> </dependency>
>
> <dependency>
>
What are the problems caused by using a scope of provided? Using
compile scope means it gets included all the time which isn't really
whats wanted which is why it was using provided scope. I guess i could
fix that by using excludes in other places but it would be better to
fix the osgi problem so provided scope works.
...ant
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
Posted by Luciano Resende <lu...@gmail.com>.
On Thu, Apr 22, 2010 at 12:18 AM, ant elder <an...@gmail.com> wrote:
>
> What are the problems caused by using a scope of provided? Using
> compile scope means it gets included all the time which isn't really
> whats wanted which is why it was using provided scope. I guess i could
> fix that by using excludes in other places but it would be better to
> fix the osgi problem so provided scope works.
>
> ...ant
>
I saw that you had explicitly added the scope provided, but after
updating the stripes to 1.5.2 I started getting issues where the OSGi
bundle with exported packages weren't being created... I tried to
verify how this was done when 1.5 version of stripes was in use but
couldn't figure out where/how to set the dependency to be bumped to
1.5.2, and the only way it was working was to change the scope of the
dependency. Maybe you could let us know if you had set it in any other
particular place...
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
Posted by Luciano Resende <lu...@gmail.com>.
On Fri, Apr 30, 2010 at 3:15 AM, ant elder <an...@apache.org> wrote:
> I'll assume silence means no one objects to this approach and I'll
> look at doing this refactor at some point.
>
> ...ant
+1 IF it makes PDE and OSGi happy.
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
Posted by ant elder <an...@apache.org>.
I'll assume silence means no one objects to this approach and I'll
look at doing this refactor at some point.
...ant
On Tue, Apr 27, 2010 at 8:39 AM, ant elder <an...@apache.org> wrote:
> Ok then how about having a separate build module for creating the PDE
> target so its not bound to the features or distributions. That way it
> can have everything it needs and it wont require everything in the
> distributions or have any impact on what we have in the features and
> distribution.
>
> ...ant
>
> On Sat, Apr 24, 2010 at 5:28 PM, Luciano Resende <lu...@gmail.com> wrote:
>> On Fri, Apr 23, 2010 at 11:05 PM, ant elder <an...@gmail.com> wrote:
>>> I'm still not sure I understand this - is the issue that when provided
>>> scope is used then the dependencies don't get added to the generated
>>> PDE target properly so there are errors when using the module in the
>>> Eclipse PDE environment?
>>>
>>> ...ant
>>
>> Yes, exactly... One would have rex x saying there is no bundle
>> exporting the package (I don't recall exact message).
>>
>>
>> --
>> Luciano Resende
>> http://people.apache.org/~lresende
>> http://twitter.com/lresende1975
>> http://lresende.blogspot.com/
>>
>
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
Posted by ant elder <an...@apache.org>.
Ok then how about having a separate build module for creating the PDE
target so its not bound to the features or distributions. That way it
can have everything it needs and it wont require everything in the
distributions or have any impact on what we have in the features and
distribution.
...ant
On Sat, Apr 24, 2010 at 5:28 PM, Luciano Resende <lu...@gmail.com> wrote:
> On Fri, Apr 23, 2010 at 11:05 PM, ant elder <an...@gmail.com> wrote:
>> I'm still not sure I understand this - is the issue that when provided
>> scope is used then the dependencies don't get added to the generated
>> PDE target properly so there are errors when using the module in the
>> Eclipse PDE environment?
>>
>> ...ant
>
> Yes, exactly... One would have rex x saying there is no bundle
> exporting the package (I don't recall exact message).
>
>
> --
> Luciano Resende
> http://people.apache.org/~lresende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
>
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
Posted by Luciano Resende <lu...@gmail.com>.
On Fri, Apr 23, 2010 at 11:05 PM, ant elder <an...@gmail.com> wrote:
> I'm still not sure I understand this - is the issue that when provided
> scope is used then the dependencies don't get added to the generated
> PDE target properly so there are errors when using the module in the
> Eclipse PDE environment?
>
> ...ant
Yes, exactly... One would have rex x saying there is no bundle
exporting the package (I don't recall exact message).
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
Posted by ant elder <an...@gmail.com>.
I'm still not sure I understand this - is the issue that when provided
scope is used then the dependencies don't get added to the generated
PDE target properly so there are errors when using the module in the
Eclipse PDE environment?
...ant
On Thu, Apr 22, 2010 at 6:26 PM, Raymond Feng <en...@gmail.com> wrote:
> Hi,
> Was the usage of "provided" to avoid the inclusions of such jars into the
> WAR?
> Since the "provided" artifact is not pulled in by maven transitive
> dependencies, they won't be added to the distribution (in turn PDE target
> platform) unless we explicitly declare them in the feature/distribution
> poms. So we either need to exclude them from the WAR (via provided scope or
> exclusions) or use the provided scope but redeclare them in the
> feature/distribution poms.
> Thanks,
> Raymond
> Raymond Feng
> rfeng@apache.org
> Apache Tuscany PMC member and committer: tuscany.apache.org
> Co-author of Tuscany SCA In Action book: www.tuscanyinaction.com
> Personal Web Site: www.enjoyjava.com
>
> On Apr 22, 2010, at 12:18 AM, ant elder wrote:
>
> On Thu, Apr 22, 2010 at 5:46 AM, <lr...@apache.org> wrote:
>
> Author: lresende
>
> Date: Thu Apr 22 04:46:56 2010
>
> New Revision: 936611
>
> URL: http://svn.apache.org/viewvc?rev=936611&view=rev
>
> Log:
>
> Changing stripes dependency scope to properly generate OSGi 'bundle' and
> avoid issues with stripes module manifest
>
> Modified:
>
> tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
>
> Modified: tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
>
> URL:
> http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml?rev=936611&r1=936610&r2=936611&view=diff
>
> ==============================================================================
>
> --- tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml (original)
>
> +++ tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml Thu Apr 22 04:46:56
> 2010
>
> @@ -46,7 +46,6 @@
>
> <groupId>net.sourceforge.stripes</groupId>
>
> <artifactId>stripes</artifactId>
>
> <version>1.5.2</version>
>
> - <scope>provided</scope>
>
> </dependency>
>
> <dependency>
>
>
> What are the problems caused by using a scope of provided? Using
> compile scope means it gets included all the time which isn't really
> whats wanted which is why it was using provided scope. I guess i could
> fix that by using excludes in other places but it would be better to
> fix the osgi problem so provided scope works.
>
> ...ant
>
>
Re: svn commit: r936611 - /tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
Posted by Raymond Feng <en...@gmail.com>.
Hi,
Was the usage of "provided" to avoid the inclusions of such jars into the WAR?
Since the "provided" artifact is not pulled in by maven transitive dependencies, they won't be added to the distribution (in turn PDE target platform) unless we explicitly declare them in the feature/distribution poms. So we either need to exclude them from the WAR (via provided scope or exclusions) or use the provided scope but redeclare them in the feature/distribution poms.
Thanks,
Raymond
Raymond Feng
rfeng@apache.org
Apache Tuscany PMC member and committer: tuscany.apache.org
Co-author of Tuscany SCA In Action book: www.tuscanyinaction.com
Personal Web Site: www.enjoyjava.com
On Apr 22, 2010, at 12:18 AM, ant elder wrote:
> On Thu, Apr 22, 2010 at 5:46 AM, <lr...@apache.org> wrote:
>> Author: lresende
>> Date: Thu Apr 22 04:46:56 2010
>> New Revision: 936611
>>
>> URL: http://svn.apache.org/viewvc?rev=936611&view=rev
>> Log:
>> Changing stripes dependency scope to properly generate OSGi 'bundle' and avoid issues with stripes module manifest
>>
>> Modified:
>> tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
>>
>> Modified: tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml
>> URL: http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml?rev=936611&r1=936610&r2=936611&view=diff
>> ==============================================================================
>> --- tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml (original)
>> +++ tuscany/sca-java-2.x/trunk/modules/stripes/pom.xml Thu Apr 22 04:46:56 2010
>> @@ -46,7 +46,6 @@
>> <groupId>net.sourceforge.stripes</groupId>
>> <artifactId>stripes</artifactId>
>> <version>1.5.2</version>
>> - <scope>provided</scope>
>> </dependency>
>>
>> <dependency>
>>
>
> What are the problems caused by using a scope of provided? Using
> compile scope means it gets included all the time which isn't really
> whats wanted which is why it was using provided scope. I guess i could
> fix that by using excludes in other places but it would be better to
> fix the osgi problem so provided scope works.
>
> ...ant