You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Rutherglen (JIRA)" <ji...@apache.org> on 2008/12/09 20:37:44 UTC
[jira] Created: (LUCENE-1484) Remove SegmentReader.document
synchronization
Remove SegmentReader.document synchronization
---------------------------------------------
Key: LUCENE-1484
URL: https://issues.apache.org/jira/browse/LUCENE-1484
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Affects Versions: 2.4
Reporter: Jason Rutherglen
This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656928#action_12656928 ]
Michael McCandless commented on LUCENE-1484:
--------------------------------------------
{quote}
> Found it "ant test-core". In the future I'll run this on the patches.
{quote}
Actually it's best if you run "ant test" (runs contrib's unit tests, too), as well as "ant test-tag" (tests back compat).
See http://wiki.apache.org/lucene-java/HowToContribute.
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656841#action_12656841 ]
Michael McCandless commented on LUCENE-1484:
--------------------------------------------
Jason I didn't understand your comment. Maybe this is the wrong issue?
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1484:
---------------------------------------
Attachment: LUCENE-1484.patch
OK I've fixed a few issues with the patch. All tests & back-compat
tests now pass. I think it's ready to commit. Jason can you review
it?
Details:
* Fixed the bug causing test failures (we were not in fact cloning
the FieldsReader in reopenSegment(), causing NPEs)
* Put back the call to isDeleted() in SegmentReader.document -- we
lost the synchronization by inlining it.
* Move fieldStreamTL.close() back out of the "if (isOriginal)" block
in FieldsReader.close.
* Put lost "private" back in front of a couple methods/members
* Added javadocs
* Removed dead code
* Added CHANGES entry
* Other small fixes...
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656852#action_12656852 ]
Jason Rutherglen commented on LUCENE-1484:
------------------------------------------
The patch is OK.
Found it "ant test-core". In the future I'll run this on the patches.
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656539#action_12656539 ]
Jason Rutherglen commented on LUCENE-1484:
------------------------------------------
It's in the ant script? I'll do this for the clone patch.
On Sun, Dec 14, 2008 at 3:04 AM, Michael McCandless (JIRA)
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670027#action_12670027 ]
Michael McCandless commented on LUCENE-1484:
--------------------------------------------
bq. Is there any chance this patch could be released in 2.4.1, instead of waiting for 2.9?
Most likely not. It's really a new feature, and it touched a fair amount of code. We normally only backport bug fixes.
Also, 2.4.0 has proven quite stable and I don't think at this point we're planning on a 2.4.1 release (at least it hasn't been discussed yet).
I'm hoping, instead, that we can release 2.9 in not too much time.
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1484.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.9
Committed revision 727338. Thanks Jason!
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Jason Bennett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667917#action_12667917 ]
Jason Bennett commented on LUCENE-1484:
---------------------------------------
Is there any chance this patch could be released in 2.4.1, instead of waiting for 2.9?
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656377#action_12656377 ]
Michael McCandless commented on LUCENE-1484:
--------------------------------------------
Jason I'm seeing multiple test case failures in TestIndexReaderReopen with this patch. Are you seeing these?
In general, can you say up front, on attaching a patch, whether it passes all tests for you, and if it doesn't, what the plan is for resolving the failures?
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Attachments: LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1484:
------------------------------------------
Assignee: Michael McCandless
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Attachments: LUCENE-1484.patch, LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1484) Remove SegmentReader.document
synchronization
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated LUCENE-1484:
-------------------------------------
Attachment: LUCENE-1484.patch
LUCENE-1484.patch
- FieldsReader implements Cloneable
- fieldsReaderLocal added to SegmentReader
- TestIndexReader, TestFieldsReader, TestSegmentReader, TestParallelMultiSearcher passes
> Remove SegmentReader.document synchronization
> ---------------------------------------------
>
> Key: LUCENE-1484
> URL: https://issues.apache.org/jira/browse/LUCENE-1484
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Attachments: LUCENE-1484.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This is probably the last synchronization issue in Lucene. It is the document method in SegmentReader. It is avoidable by using a threadlocal for FieldsReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org