You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/01/06 21:59:33 UTC
Review Request 55282: AMBARI-19405. Allow running a subset of Python
unit tests in ambari-agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55282/
-----------------------------------------------------------
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19405
https://issues.apache.org/jira/browse/AMBARI-19405
Repository: ambari
Description
-------
`unitTests.py` already handles command-line argument as test file mask. Changed `pom.xml` to pass mask defined by `python.test.mask` property. Defaults to "all tests".
Diffs
-----
ambari-agent/pom.xml 35fba19d6ac7ff26e03b3625acdfbf7671355e3b
Diff: https://reviews.apache.org/r/55282/diff/
Testing
-------
Without patch:
```
$ mvn -pl ambari-agent -DskipSurefireTests test
...
Ran 452 tests in 11.129s
OK
```
With patch:
```
$ mvn -pl ambari-agent -DskipSurefireTests test
...
Ran 452 tests in 11.407s
OK
$ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask=TestUserResource test
...
Ran 12 tests in 0.082s
OK
$ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask='Test*Resource' test
...
Ran 108 tests in 0.428s
OK
```
Thanks,
Attila Doroszlai
Re: Review Request 55282: AMBARI-19405. Allow running a subset of
Python unit tests in ambari-agent.
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55282/#review160890
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On Jan. 6, 2017, 9:59 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55282/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 9:59 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19405
> https://issues.apache.org/jira/browse/AMBARI-19405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> `unitTests.py` already handles command-line argument as test file mask. Changed `pom.xml` to pass mask defined by `python.test.mask` property. Defaults to "all tests".
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 35fba19d6ac7ff26e03b3625acdfbf7671355e3b
>
> Diff: https://reviews.apache.org/r/55282/diff/
>
>
> Testing
> -------
>
> Without patch:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 452 tests in 11.129s
>
> OK
> ```
>
> With patch:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 452 tests in 11.407s
>
> OK
>
> $ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask=TestUserResource test
> ...
> Ran 12 tests in 0.082s
>
> OK
>
> $ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask='Test*Resource' test
> ...
> Ran 108 tests in 0.428s
>
> OK
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 55282: AMBARI-19405. Allow running a subset of
Python unit tests in ambari-agent.
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55282/#review160833
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 6, 2017, 10:59 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55282/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 10:59 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19405
> https://issues.apache.org/jira/browse/AMBARI-19405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> `unitTests.py` already handles command-line argument as test file mask. Changed `pom.xml` to pass mask defined by `python.test.mask` property. Defaults to "all tests".
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 35fba19d6ac7ff26e03b3625acdfbf7671355e3b
>
> Diff: https://reviews.apache.org/r/55282/diff/
>
>
> Testing
> -------
>
> Without patch:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 452 tests in 11.129s
>
> OK
> ```
>
> With patch:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 452 tests in 11.407s
>
> OK
>
> $ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask=TestUserResource test
> ...
> Ran 12 tests in 0.082s
>
> OK
>
> $ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask='Test*Resource' test
> ...
> Ran 108 tests in 0.428s
>
> OK
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 55282: AMBARI-19405. Allow running a subset of
Python unit tests in ambari-agent.
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55282/#review160836
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On Jan. 6, 2017, 9:59 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55282/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 9:59 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19405
> https://issues.apache.org/jira/browse/AMBARI-19405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> `unitTests.py` already handles command-line argument as test file mask. Changed `pom.xml` to pass mask defined by `python.test.mask` property. Defaults to "all tests".
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 35fba19d6ac7ff26e03b3625acdfbf7671355e3b
>
> Diff: https://reviews.apache.org/r/55282/diff/
>
>
> Testing
> -------
>
> Without patch:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 452 tests in 11.129s
>
> OK
> ```
>
> With patch:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 452 tests in 11.407s
>
> OK
>
> $ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask=TestUserResource test
> ...
> Ran 12 tests in 0.082s
>
> OK
>
> $ mvn -pl ambari-agent -DskipSurefireTests -Dpython.test.mask='Test*Resource' test
> ...
> Ran 108 tests in 0.428s
>
> OK
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>