You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "wuchong (via GitHub)" <gi...@apache.org> on 2023/03/23 15:25:25 UTC
[GitHub] [flink] wuchong opened a new pull request, #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction
wuchong opened a new pull request, #22254:
URL: https://github.com/apache/flink/pull/22254
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Removes the usage of the deprecated method `TableEnvironment#registerFunction`.
## Brief change log
- Replace the usage of `TableEnvironment#registerFunction` with `TableEnvironment#createTemporarySystemFunction`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on PR #22254:
URL: https://github.com/apache/flink/pull/22254#issuecomment-1500915644
I tried to cleanup the registerFunction usage. But it seems it is a big effort because of the different behavior between `registerFunction` and `createTemporarySystemFunction`, e.g., the error message, the checks of nullability types, the plan digests, etc. I would like to close this PR first, and may separate it into sub-tasks later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #22254:
URL: https://github.com/apache/flink/pull/22254#issuecomment-1482209920
ci failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #22254:
URL: https://github.com/apache/flink/pull/22254#issuecomment-1482573035
Shouldn't it be replaced with `createTemporarySystemFunction` as mentioned in javadoc?
```
* @deprecated Use {@link #createTemporarySystemFunction(String, UserDefinedFunction)} instead.
* Please note that the new method also uses the new type system and reflective extraction
* logic. It might be necessary to update the function implementation as well. See the
* documentation of {@link ScalarFunction} for more information on the new function design.
```
Also with new approaches to checks types for nullability. And there will be an issue with `org.apache.flink.table.planner.runtime.utils.JavaUserDefinedScalarFunctions.NonDeterministicUdf` since it has inputs as primitives in java (will be translated to `NOT NULL`) and used in scala tests for `util.addTableSource[(Int, Int, String)]("MyTable", 'a, 'b, 'c)` which are nullable.
I guess either test should be moved to java to test it with primitives or function definition should be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong closed pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction
URL: https://github.com/apache/flink/pull/22254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22254:
URL: https://github.com/apache/flink/pull/22254#issuecomment-1481408631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cb3506d40f2134224c2b93c13cafd77e7914395e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb3506d40f2134224c2b93c13cafd77e7914395e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb3506d40f2134224c2b93c13cafd77e7914395e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org