You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/07/15 08:06:27 UTC

[GitHub] [fineract] galovics commented on a diff in pull request #2428: Quick code cleaning for client and loan: around the native queries

galovics commented on code in PR #2428:
URL: https://github.com/apache/fineract/pull/2428#discussion_r921916968


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientChargeReadPlatformServiceImpl.java:
##########
@@ -151,7 +151,7 @@ public Page<ClientChargeData> retrieveClientCharges(Long clientId, String status
         // filter for paid charges
         if (pendingPayment != null && pendingPayment) {

Review Comment:
   I know you haven't implemented this but since you touched the other condition, can we maybe switch this to BooleanUtils.isTrue and respectively BooleanUtils.isFalse?
   
   Much easier to read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org