You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/07 14:28:57 UTC
[GitHub] [systemds] OlgaOvcharenko opened a new pull request #1266: [WIP] Modified federated broadcast and broadcastSliced
OlgaOvcharenko opened a new pull request #1266:
URL: https://github.com/apache/systemds/pull/1266
This PR modifies federated broadcast and broadcastSliced. Instead of putting the variable and then cleaning after instruction execution new FederatedData is initialized and reused after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] OlgaOvcharenko closed pull request #1266: [WIP] Modified federated broadcast and broadcastSliced
Posted by GitBox <gi...@apache.org>.
OlgaOvcharenko closed pull request #1266:
URL: https://github.com/apache/systemds/pull/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1266: [WIP] Modified federated broadcast and broadcastSliced
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1266:
URL: https://github.com/apache/systemds/pull/1266#issuecomment-846567170
Thanks for getting started on this consolidation of broadcasts @OlgaOvcharenko. With the rework of the federation map, there should however, no longer be a need for separate broadcast maps, etc because every broadcast (replicated or sliced) is just handled like any other federated data. The reuse of broadcasts will then be done via simple checks for aligned federated inputs (which we will improve subsequently for all operations, in fact @ywcb00 will make a full pass over all instructions to ensure we don't miss any).
Could you maybe try to simplify the PR and let me know once you're ready, then I'll make a pass and help finalize it if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org