You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2023/02/04 07:42:59 UTC

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1165: [LOG4J2-3642] Consider Osgi versions older than 1.5 as not available.

ppkarwasz commented on PR #1165:
URL: https://github.com/apache/logging-log4j2/pull/1165#issuecomment-1416688714

   @adwsingh,
   
   I reverted back to your first idea of checking for `FrameworkUtil#getBundle`: if the method exists (OSGI 4.2) and returns `null`, we are not running in an OSGI container and `OsgiServiceLocator` should be disabled regardless of the OSGI version on the classpath.
   
   You can test this by running `mvn verify -pl log4j-api-test -Dosgi.api.version=X` with values of X in `4.0.0`, `4.1.0` and `4.2.0`.
   
   What name should we put in the changelog for this PR and #1127 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org