You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/02/24 17:32:49 UTC
[GitHub] [ratis] adoroszlai opened a new pull request #429: RATIS-1322. Cannot build from source without repo
adoroszlai opened a new pull request #429:
URL: https://github.com/apache/ratis/pull/429
## What changes were proposed in this pull request?
Fix the build error that occurs if Ratis directory is not a git repo (which would happen when building from release source artifact):
```
[INFO] Apache Ratis ....................................... FAILURE [ 0.819 s]
...
[ERROR] Failed to execute goal org.codehaus.mojo:buildnumber-maven-plugin:1.4:create-metadata (default) on project ratis: Execution default of goal org.codehaus.mojo:buildnumber-maven-plugin:1.4:create-metadata failed.: NullPointerException -> [Help 1]
```
`revision` in `ratis-version.properties` is set to `Unknown` in this case. This matches Ozone's properties for the same situation.
https://issues.apache.org/jira/browse/RATIS-1322
## How was this patch tested?
```
$ mvn -DskipTests clean verify; cat target/classes/ratis-version.properties
...
version=1.1.0-SNAPSHOT
revision=1ce8621b295678c780ad7adaf5621d8114fdefc3
name=Apache Ratis
timestamp=1614187092964
$ rm -fr .git
$ mvn -DskipTests clean verify; cat target/classes/ratis-version.properties
...
version=1.1.0-SNAPSHOT
revision=Unknown
name=Apache Ratis
timestamp=1614187444515
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] runzhiwang merged pull request #429: RATIS-1322. Cannot build from source without repo
Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #429:
URL: https://github.com/apache/ratis/pull/429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org