You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/13 07:47:04 UTC

[GitHub] sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value

sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value
URL: https://github.com/apache/bookkeeper/pull/1252#issuecomment-372575452
 
 
   >  may this change break existing tests, or at least change the meaning of what is tested ?
   
   CI will tell. 
   
   > we should add a test about this change, at least on the new API
   
   There is already change testing the feature itself. so I don't think it need a new test for that, which sounds redundant and not useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services