You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/08 11:44:46 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #739: MINIFICPP-1163 Implemented.

szaszm commented on a change in pull request #739: MINIFICPP-1163 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/739#discussion_r405453588
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -53,7 +53,7 @@ option(FORCE_WINDOWS "Instructs the build system to force Windows builds when WI
 option(DISABLE_CURL "Disables libCurl Properties." OFF)
 
 option(USE_GOLD_LINKER "Use Gold Linker" OFF)
-
+option(INSTALLER_MERGE_MODULES "Creates installer with merge modules" OFF)
 
 Review comment:
   Currently we build with merge modules. This changes to shipped dlls by default. Do we want that?
   
   If you change the PR to the old behavior, please have a look at win_build_vs.bat as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services