You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/03/26 00:28:43 UTC
svn commit: r1581597 - /tomcat/trunk/java/javax/el/Util.java
Author: markt
Date: Tue Mar 25 23:28:43 2014
New Revision: 1581597
URL: http://svn.apache.org/r1581597
Log:
Code review
- lock outside try/catch/finally
Modified:
tomcat/trunk/java/javax/el/Util.java
Modified: tomcat/trunk/java/javax/el/Util.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/Util.java?rev=1581597&r1=1581596&r2=1581597&view=diff
==============================================================================
--- tomcat/trunk/java/javax/el/Util.java (original)
+++ tomcat/trunk/java/javax/el/Util.java Tue Mar 25 23:28:43 2014
@@ -118,8 +118,8 @@ class Util {
if (factory == null) {
final Lock writeLock = cacheValue.getLock().writeLock();
+ writeLock.lock();
try {
- writeLock.lock();
factory = cacheValue.getExpressionFactory();
if (factory == null) {
factory = ExpressionFactory.newInstance();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org