You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "wizhuo (via GitHub)" <gi...@apache.org> on 2023/02/22 06:21:54 UTC
[GitHub] [shardingsphere-elasticjob] wizhuo opened a new pull request, #2187: Adjust JobScheduler init sequence to avoid use wrong ElasticJobListener
wizhuo opened a new pull request, #2187:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2187
…ner when the config overwrite is false
Fixes #ISSUSE_ID.
Adjust JobScheduler init sequence to avoid use wrong ElasticJobListener when the overwrite is false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #2187: Adjust JobScheduler init sequence to avoid use wrong ElasticJobListener
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN merged PR #2187:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wizhuo commented on pull request #2187: Adjust JobScheduler init sequence to avoid use wrong ElasticJobListener
Posted by "wizhuo (via GitHub)" <gi...@apache.org>.
wizhuo commented on PR #2187:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2187#issuecomment-1445353064
please help me to review @TeslaCN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wizhuo commented on pull request #2187: Adjust JobScheduler init sequence to avoid use wrong ElasticJobListener
Posted by "wizhuo (via GitHub)" <gi...@apache.org>.
wizhuo commented on PR #2187:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2187#issuecomment-1446487606
> > please help me to review @TeslaCN
>
> Do we still need the `SetUpFacade#setUpJobConfiguration` after your changes? Could we just remove it?
yes ,I had remove it ,please check it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wizhuo commented on pull request #2187: Adjust JobScheduler init sequence to avoid use wrong ElasticJobListener
Posted by "wizhuo (via GitHub)" <gi...@apache.org>.
wizhuo commented on PR #2187:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2187#issuecomment-1439555851
#2188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #2187: Adjust JobScheduler init sequence to avoid use wrong ElasticJobListener
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #2187:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2187#issuecomment-1446177701
> please help me to review @TeslaCN
Do we still need the `SetUpFacade#setUpJobConfiguration` after your changes? Could we just remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org