You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/04 08:02:03 UTC
[GitHub] [beam] bullet03 opened a new pull request, #17260: Beam 13229 bug side bav
bullet03 opened a new pull request, #17260:
URL: https://github.com/apache/beam/pull/17260
[BEAM-13229]
- change offset to 1px to activate an element via bootstrap's scrollspy library
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17260:
URL: https://github.com/apache/beam/pull/17260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1112910914
like I said, please let's make sure that the issue that ritesh caught did not just get merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17260: Beam 13229 bug side bav
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1087237286
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1109529611
> @bullet03 Thanks for the PR. It solves the original problem of changing sections on side nav. However, it looks like the orange scroll bar in side nav gets collapsed as horizontal lines before moving to its original position. Could you do another pass? Would be happy to get this change in once the orange lines are gone.
The arrow images are not shown on staging in any PR, so it is not caused by the changes in 17260. They are shown correctly on localhost, so we couldn't reproduce the bug there.
There is a high probability that, when we merge the code to master, this issue will be fixed.
Which means, there might be another issue - with CI/CD - that is worth investigating. Should we create another ticket in Jira and describe the issue there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on pull request #17260: Beam 13229 bug side bav
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1087839489
I still can reproduce this bug on the [documentation page](http://apache-beam-website-pull-requests.storage.googleapis.com/17260/documentation/programming-guide/index.html#transforms)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1105662908
R: @riteshghorse - could you do a first pass review and tag a committer after that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1112513650
Run Website_Stage_GCS PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17260: Beam 13229 bug side bav
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1087237283
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #17260: Beam 13229 bug side bav
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1087237467
R: @AydarZaynutdinov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
nausharipov commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1113156804
@pabloem Ritesh's issue with arrow images not being displayed on staging is not present on the master branch after the merge. We will create a separate Jira ticket describing this CI/CD issue.
We have created PR #17503 to revert the changes from this branch because the menu still works incorrectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dariabezkorovaina commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
dariabezkorovaina commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1113651331
Created a [ Jira ticket ](https://issues.apache.org/jira/browse/BEAM-14384) to investigate issue with CI/CD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17260: Beam 13229 bug side bav
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1087237285
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1112910641
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1106534419
@bullet03 Thanks for the PR. It solves the original problem of changing sections on side nav. However, it looks like the orange scroll bar in side nav gets collapsed as horizontal lines before moving to its original position.
Could you do another pass? Would be happy to get this change in once the orange lines are gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dariabezkorovaina commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
dariabezkorovaina commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1111403272
@pabloem I heard that Kiley is OOO for this and next week, can you please help with merging this PR? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17260: Beam 13229 bug side bav
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1087237284
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1109792702
Sounds good to me. I'll tag a committer and let's see their take on it.
R: @kileys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1112910516
let's just make sure that the issue does not reproduce once merged...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #17260: [BEAM-13229] [Website] bug side nav
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #17260:
URL: https://github.com/apache/beam/pull/17260#issuecomment-1106529321
It solves the original problem but introduces new orange lines under the side section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org