[GitHub] [ignite] shishkovilja commented on a change in pull request #9766: IGNITE-16387 Improve CDC monitoring and logging

[GitBox <gi...@apache.org>]

shishkovilja commented on a change in pull request #9766:
URL: https://github.com/apache/ignite/pull/9766#discussion_r792597349



##########
File path: modules/core/src/main/java/org/apache/ignite/spi/systemview/view/CacheView.java
##########
@@ -39,13 +42,18 @@
  */
 public class CacheView {
     /** Cache descriptor. */
-    private DynamicCacheDescriptor cache;
+    private final DynamicCacheDescriptor cache;
+
+    /** Kernal context. */
+    private final GridKernalContext ctx;
+

Review comment:
       Reduntant empty line.

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersionManager.java
##########
@@ -99,6 +102,8 @@
 
         lastDataVer = sysreg.longMetric(LAST_DATA_VER, "The latest data version on the node.");
 
+        sysreg.register(DATA_CENTER_ID, () -> dataCenterId, "Data center id");

Review comment:
       Should we document this metric in new-metrics.adoc?

##########
File path: modules/core/src/test/java/org/apache/ignite/cdc/CdcCacheVersionTest.java
##########
@@ -49,10 +49,16 @@
 import org.apache.ignite.plugin.AbstractTestPluginProvider;
 import org.apache.ignite.plugin.CachePluginContext;
 import org.apache.ignite.plugin.CachePluginProvider;
+import org.apache.ignite.spi.metric.IntMetric;
+import org.apache.ignite.spi.systemview.view.CacheView;
+import org.apache.ignite.spi.systemview.view.SystemView;
 import org.jetbrains.annotations.Nullable;
 import org.junit.Test;
 
 import static org.apache.ignite.cluster.ClusterState.ACTIVE;
+import static org.apache.ignite.internal.processors.cache.CacheMetricsImpl.CACHE_METRICS;
+import static org.apache.ignite.internal.processors.cache.ClusterCachesInfo.CACHES_VIEW;
+import static org.apache.ignite.internal.processors.cache.version.GridCacheVersionManager.*;

Review comment:
       Start import should be replaced by direct ones.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org