You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2011/08/22 01:24:28 UTC
[jira] [Created] (QPID-3440) the Destination cache in
AMQMessageDelegate_0_10 does not work
the Destination cache in AMQMessageDelegate_0_10 does not work
--------------------------------------------------------------
Key: QPID-3440
URL: https://issues.apache.org/jira/browse/QPID-3440
Project: Qpid
Issue Type: Bug
Components: Java Client
Affects Versions: 0.10, 0.9, 0.8, 0.7, 0.6, 0.11, 0.12
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
Fix For: 0.13
The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3440) the Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3440:
---------------------------------
Attachment: QPID-3440_wip.patch
Attaching an initial patch, with test to verify the issue and addition of equals() and hashCode() methods to the generated file causing the problem.
Not yet applied becuase doing so breaks PropertyValueTest. This is due to failing a Destination equality test, despite the fact the toString of the destinations is actually the same (which it wasnt before), but the equals check fails because of a change in underlying object in use, due to the horrible number of different objects and ways to instantiate them in our wonderfully dispirate Destination handling.
> the Destination cache in AMQMessageDelegate_0_10 does not work
> --------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments: QPID-3440_wip.patch
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3440) the Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3440:
---------------------------------
Affects Version/s: 0.14
0.13
Fix Version/s: (was: 0.13)
0.15
> the Destination cache in AMQMessageDelegate_0_10 does not work
> --------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3440) the reply-to Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3440:
---------------------------------
Status: Ready To Review (was: In Progress)
> the reply-to Destination cache in AMQMessageDelegate_0_10 does not work
> -----------------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3440) the Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206594#comment-13206594 ]
Robbie Gemmell commented on QPID-3440:
--------------------------------------
Added a test to verify the issue, and its resolution following addition of equals() and hashCode() methods to the generated file causing the problem. Updated the reply-to cache in line with the 0-8/0-9/0-9-1 model of using a LinkedHashMap which will cache the most recent 500 Destinations rather than just SoftReferencing them all.
> the Destination cache in AMQMessageDelegate_0_10 does not work
> --------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3440) the Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3440:
---------------------------------
Attachment: (was: QPID-3440_wip.patch)
> the Destination cache in AMQMessageDelegate_0_10 does not work
> --------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3440) the reply-to Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3440:
------------------------------------
Assignee: Keith Wall (was: Robbie Gemmell)
Keith, could you review these changes please?
Thanks,
Robbie
> the reply-to Destination cache in AMQMessageDelegate_0_10 does not work
> -----------------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3440) the reply-to Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3440.
----------------------------------
Resolution: Fixed
Assignee: Rob Godfrey (was: Keith Wall)
Closing out, Rob reviewed the commit while the new test was failing on his Sonar runs (due to a configuration issue with the Sonar build run)
> the reply-to Destination cache in AMQMessageDelegate_0_10 does not work
> -----------------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14
> Reporter: Robbie Gemmell
> Assignee: Rob Godfrey
> Fix For: 0.15
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3440) the Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3440:
---------------------------------
Comment: was deleted
(was: Attaching an initial patch, with test to verify the issue and addition of equals() and hashCode() methods to the generated file causing the problem.
Not yet applied becuase doing so breaks PropertyValueTest. This is due to failing a Destination equality test, despite the fact the toString of the destinations is actually the same (which it wasnt before), but the equals check fails because of a change in underlying object in use, due to the horrible number of different objects and ways to instantiate them in our wonderfully dispirate Destination handling.)
> the Destination cache in AMQMessageDelegate_0_10 does not work
> --------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3440) the reply-to Destination cache in
AMQMessageDelegate_0_10 does not work
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3440:
---------------------------------
Summary: the reply-to Destination cache in AMQMessageDelegate_0_10 does not work (was: the Destination cache in AMQMessageDelegate_0_10 does not work)
> the reply-to Destination cache in AMQMessageDelegate_0_10 does not work
> -----------------------------------------------------------------------
>
> Key: QPID-3440
> URL: https://issues.apache.org/jira/browse/QPID-3440
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Destination cache in AMQMessageDelegate_0_10 does not work, because it indexes the cache by the underlying ReplyTo transport class, which has no equals() implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org