[GitHub] [airflow] potiuk commented on a change in pull request #21356: Standardize approach to dependencies

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #21356:
URL: https://github.com/apache/airflow/pull/21356#discussion_r800722140



##########
File path: setup.py
##########
@@ -292,65 +302,72 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pygithub',
 ]
 google = [
+    # Google has very clear rules on what dependencies should be used. All the limits below
+    # follow strict guidelines of Google Libraries as quoted here:
+    # While this issue is open, dependents of google-api-core, google-cloud-core. and google-auth
+    # should preserve >1, <3 pins on these packages.
+    # https://github.com/googleapis/google-cloud-python/issues/10566
+    # Some of Google Packages are limited to <2.0.0 because 2.0.0 releases of the libraries
+    # Introduced breaking changes across the board. Those libraries should be upgraded soon
+    # TODO: Upgrade all Google libraries that are limited to <2.0.0

Review comment:
       Yep . I think I kept all `< 2.0.0` where they were there and only removed the <3, <4 which are future-unknown-if-ever-happens-and-what-the-scope-of-breakage-will-be ones. Let me re-review if I did it right.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org