[GitHub] [airflow] potiuk commented on issue #6681: [AIRFLOW-6089] Order setup add ci

[GitBox <gi...@apache.org>]

potiuk commented on issue #6681: [AIRFLOW-6089] Order setup add ci
URL: https://github.com/apache/airflow/pull/6681#issuecomment-559746595
 
 
   Hey @zhongjiajie -> It's super cool change. I have one suggestion though. Your test does not require full airflow set of dependencies to run - it's rather standalone, so you can run it as a "python" pre-commit check - similar to isort. Then you would not need all the scripts (they are only needed if you want to run stuff inside docker container).
   
   something like that could work:
   
   ```
         - id: setup-order
           name: Checks for an order of dependencies in setup.py
           language: python
           files: ^setup.py$
           pass_filenames: false
           require_serial: true
           entry: tests/test_order_setup.py
   ```
   
   It will automatically create a separate virtualenv for this check and run the test in this virtualenv.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services