You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/08 09:24:58 UTC

[GitHub] [skywalking] wwwlla opened a new issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

wwwlla opened a new issue #5268:
URL: https://github.com/apache/skywalking/issues/5268


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [√] Bug
   
   
   ___
   ### Question
   - What do you want to know?
   How can I get traceId in my log when I use Spring Cloud Gateway ,all traceId in my log is "[traceId:TID:N/A]".
   The log get traceId can work well in other project
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
          version of SkyWalking :  8.2.0  (use SpringCloudGateWay and apm-spring-cloud-gateway-2.1.x-plugin)
          OS:   windows and linux
          JRE:   java8
          
   
   - What happened?
   When this happen, I try move "ContextManager.stopSpan(span);" from  beforeMethod to afterMethod in DispatcherHandlerHandleMethodInterceptor. When I did this, log has traceId,but in SkyWalking server ,one traceId has a lot of API
   
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690838611






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 295black commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
295black commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-892608073


   any update regarding this issue? i am also frustrated about this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690848454


   So...Back to the beginning, How to get TraceId correcttly in SCG :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx edited a comment on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx edited a comment on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690838065


   Modify spring-webflux agent like this:
   ![image](https://user-images.githubusercontent.com/26428832/92846241-722b7880-f41a-11ea-8d2e-4763e400c526.png)
   
   in your SCG project:
   String TraceId = serverWebExchange.getAttribute("global.trace.id");


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690844149


   It should relate to context, which relating to it is the question.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 9989836 commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
9989836 commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-697113842


   @ascrutae  We need to record traceid in SCG.  How to achieve it?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690844642


   The concern of this change is, if user use the same key, it breaks. And this provide the different API to end users, it is confused to users.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690838611






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690985584






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690836096






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690985584


   @ascrutae is doing some tests, that is why this PR is assigned to him.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690841360


   > We have no plan to set trace id in user codes to avoid conflict.
   
   But, in async scenario, There is no way to get TraceId of per request, must relate to Context.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690838065


   Modify spring-webflux like this:
   ![image](https://user-images.githubusercontent.com/26428832/92846241-722b7880-f41a-11ea-8d2e-4763e400c526.png)
   
   in your SCG project:
   String TraceId = serverWebExchange.getAttribute("global.trace.id");


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690838611


   We have no plan to set trace id in user codes to avoid conflict.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] aliuql commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
aliuql commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-994710234


   i am also frustrated about this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 295black commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
295black commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-892608073


   any update regarding this issue? i am also frustrated about this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5268:
URL: https://github.com/apache/skywalking/issues/5268


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wwwlla commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wwwlla commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-671175545


   version of SpringCloudGateway in my project is 2.2.3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx edited a comment on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx edited a comment on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690838065


   Modify spring-webflux agent like this:
   ![image](https://user-images.githubusercontent.com/26428832/92846241-722b7880-f41a-11ea-8d2e-4763e400c526.png)
   
   in your SCG project:
   String TraceId = serverWebExchange.getAttribute("global.trace.id");


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5268:
URL: https://github.com/apache/skywalking/issues/5268


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690836096






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690846392


   Why not give the authority to the user to decide the key name by config file instead of providing API?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690836096


   You should set TraceId into ServerWebExchange in the agent, so that you will get TraceId from ServerWebExchange attribute.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] pkbrown608 commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
pkbrown608 commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-747242533


   any update regarding this issue? i am also frustrated about this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690847667


   Bit still two API. We never did this before. Because  one day, you could ask for tag, log or new span in the context. 
   We have to fix the thing in right theory, rather than keep breaking things.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] xiaoyao2246 commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
xiaoyao2246 commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-804719000


   any update regarding this issue? i am also frustrated about this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Lovnx edited a comment on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
Lovnx edited a comment on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-690838065


   Modify spring-webflux agent like this:
   ![image](https://user-images.githubusercontent.com/26428832/92846241-722b7880-f41a-11ea-8d2e-4763e400c526.png)
   
   in your SCG project:
   String TraceId = serverWebExchange.getAttribute("global.trace.id");


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 9989836 commented on issue #5268: My log can't get traceId when I use Spring Cloud Gateway in my project ,all traceId in my log is "[traceId:TID:N/A]"

Posted by GitBox <gi...@apache.org>.
9989836 commented on issue #5268:
URL: https://github.com/apache/skywalking/issues/5268#issuecomment-697113842


   @ascrutae  We need to record traceid in SCG.  How to achieve it?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org