You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/01/08 12:48:00 UTC
[jira] [Commented] (GROOVY-10898) Provide tail/init for primitive arrays
[ https://issues.apache.org/jira/browse/GROOVY-10898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655789#comment-17655789 ]
ASF GitHub Bot commented on GROOVY-10898:
-----------------------------------------
codecov-commenter commented on PR #1842:
URL: https://github.com/apache/groovy/pull/1842#issuecomment-1374828179
# [Codecov](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1842](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81ed389) into [master](https://codecov.io/gh/apache/groovy/commit/8f80995b4a116ca65ca1536df8f7f65abc08dac6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f80995) will **decrease** coverage by `0.0173%`.
> The diff coverage is `33.3333%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/groovy/pull/1842/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1842 +/- ##
==================================================
- Coverage 67.7474% 67.7300% -0.0173%
- Complexity 28300 28316 +16
==================================================
Files 1427 1427
Lines 112611 112659 +48
Branches 19302 19302
==================================================
+ Hits 76291 76304 +13
- Misses 29795 29812 +17
- Partials 6525 6543 +18
```
| [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `51.8625% <33.3333%> (-2.9548%)` | :arrow_down: |
| [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `35.2349% <0.0000%> (-0.5034%)` | :arrow_down: |
> Provide tail/init for primitive arrays
> --------------------------------------
>
> Key: GROOVY-10898
> URL: https://issues.apache.org/jira/browse/GROOVY-10898
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-jdk
> Reporter: Paul King
> Assignee: Paul King
> Priority: Minor
> Fix For: 5.0.0-alpha-1
>
>
> Consider the following:
> {code:groovy}
> @groovy.transform.TypeChecked
> void test(int[] ints) {
> ints.eachWithIndex { value, index ->
> println "$index: ${value.doubleValue()}"
> }
> }
> test(0,1,2,3,4,5)
> {code}
> Compiler reports "[Static type checking] - Cannot find matching method java.lang.Object#doubleValue()"
> {{eachWithIndex}} is only provided for reference types, so "value" is seen as Object by the type checker.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)