You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2018/12/05 03:17:45 UTC
[GitHub] nifi-minifi pull request #148: MINIFI-482 Provide support for multiple URIs.
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/148
MINIFI-482 Provide support for multiple URIs.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi MINIFI-482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #148
----
commit 98976bcbd538ece2f813c68fe3ce7d811628cae1
Author: Aldrin Piri <al...@...>
Date: 2018-12-04T22:27:57Z
MINIFI-482 Provide support for multiple URIs.
----
---
[GitHub] nifi-minifi pull request #148: MINIFI-482 Provide support for multiple URIs.
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/148#discussion_r239213358
--- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessGroupSchema.java ---
@@ -151,7 +152,7 @@ public String getComment() {
return comment;
}
- public String getUrl() {
+ public String getUrls() {
return url;
--- End diff --
Super minor and I honestly didn't look too close to see if it makes sense, but would it be beneficial at all to rename `url` to `urls`, too?
---
[GitHub] nifi-minifi pull request #148: MINIFI-482 Provide support for multiple URIs.
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/148#discussion_r239583364
--- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessGroupSchema.java ---
@@ -151,7 +152,7 @@ public String getComment() {
return comment;
}
- public String getUrl() {
+ public String getUrls() {
return url;
--- End diff --
yeah, that would make sense. will fix!
---
[GitHub] nifi-minifi pull request #148: MINIFI-482 Provide support for multiple URIs.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/148
---