You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/02/08 19:26:41 UTC

[GitHub] brodybits opened a new pull request #248: CB-13834 TEST WIP FOR DISCUSSION DO NOT MERGE

brodybits opened a new pull request #248: CB-13834 TEST WIP FOR DISCUSSION DO NOT MERGE
URL: https://github.com/apache/cordova-windows/pull/248
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Windows
   
   ### What does this PR do?
   
   Further testing to help narrow down the cause of CB-13834 (<https://issues.apache.org/jira/browse/CB-13834>) test failures
   
   OBSERVATION: For some reason it would only generate x64 build for UWP bundle in case of VS 2017 on AppVeyor build
   
   Output on my fork is available at: <https://ci.appveyor.com/project/brodybits/cordova-windows-u6yx9/build/1.0.13/job/vpstha4h1l4879hc> (same results are expected to show up for this PR)
   
   NOTICE: This PR is for investigation and discussion only. PLEASE DO NOT MERGE.
   
   ### What testing has been done on this change?
   
   - appveyor.yml replace Node 4 with Node 8 to rule out possible effect of outdated Node.js version
   - additional logs (commented out) used to get a better understanding of actual output
   - fixed related test descriptions
   - added test of UWP bundle for x64 only (seems to pass on AppVeyor)
   - add extra expectation to spec.6a to check for generated bundle for x64 only
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database (reported by someone else): <https://issues.apache.org/jira/browse/CB-13834>
   ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~ not done here (raised for investigation and discussion only)
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org