You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/06/03 16:19:33 UTC

[GitHub] incubator-brooklyn pull request: Fix tests on Windows

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/677

    Fix tests on Windows

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn fix/windows-150603

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #677
    
----
commit 74d878851f3b0e1c89180789114a793e57d5b3cc
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-06-03T14:18:24Z

    Fix tests on Windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix tests on Windows

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/677


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix tests on Windows

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/677#discussion_r31641317
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/PeriodicDeltaChangeListener.java ---
    @@ -278,7 +278,9 @@ public void waitForPendingComplete(Duration timeout, boolean canTrigger) throws
                     while (writeCount.get() <= targetWriteCount) {
                         Duration left = timer.getDurationRemaining();
                         if (left.isPositive()) {
    -                        writeCount.wait(left.lowerBound(Duration.millis(10)).toMilliseconds());
    +                        synchronized(writeCount) {
    +                            writeCount.wait(left.lowerBound(Duration.millis(10)).toMilliseconds());
    --- End diff --
    
    wow, that was a bad bug to sneak in! Thanks for fixing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix tests on Windows

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/677#issuecomment-108510276
  
    Looks good; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---