You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/16 08:06:04 UTC

[GitHub] [cordova-plugin-inappbrowser] rak13 opened a new pull request #581: Allow user to override userAgent

rak13 opened a new pull request #581: Allow user to override userAgent
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/581
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   
   ### Motivation and Context
   Allow user to override userAgent
   Can use google-login, google login does not work with default Webview user-agent
   
   
   
   ### Description
   Added a new option in `customizableOptions` and used this value in `overrideUserAgent` variable which was previously `null`
   
   
   ### Testing
   Tested with the google-login flow in both android and iOS
   Things work as usual if 'OverrideUserAgent` is not provided in the options
   
   
   ### Checklist
   
   - [ x ] I've run the tests to see all new and existing tests pass
   - [ x ] I added automated test coverage as appropriate for this change
   - [ x ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ x ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org