You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com> on 2017/04/07 15:04:52 UTC
Re: Review Request 57451: The Installation of hbase-client failed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
-----------------------------------------------------------
(Updated \u56db\u6708 7, 2017, 3:04 p.m.)
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368
Repository: ambari
Description
-------
The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
Diff: https://reviews.apache.org/r/57451/diff/2/
Changes: https://reviews.apache.org/r/57451/diff/1-2/
Testing
-------
done it
File Attachments (updated)
----------------
AMBARI-20368.patch
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
Thanks,
zhangxiaolu zhangxiaolu
Re: Review Request 57451: The Installation of hbase-client failed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review172097
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Line 115 (original)
<https://reviews.apache.org/r/57451/#comment245174>
Just curious, did someone from the Hbase project confirm this change?
- Alejandro Fernandez
On April 14, 2017, 4:52 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> -----------------------------------------------------------
>
> (Updated April 14, 2017, 4:52 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 20894ec
>
>
> Diff: https://reviews.apache.org/r/57451/diff/6/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20368.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
-----------------------------------------------------------
(Updated \u56db\u6708 14, 2017, 4:52 a.m.)
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368
Repository: ambari
Description
-------
The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 20894ec
Diff: https://reviews.apache.org/r/57451/diff/6/
Changes: https://reviews.apache.org/r/57451/diff/5-6/
Testing
-------
done it
File Attachments
----------------
AMBARI-20368.patch
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
Thanks,
zhangxiaolu zhangxiaolu
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
> On \u56db\u6708 12, 2017, 4:35 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > <https://reviews.apache.org/r/57451/diff/5/?file=1686957#file1686957line67>
> >
> > I've actually never seen this, so perhaps a more appropriate fix would be in HDFS Client instead.
> > HDFS Client itself should ensure that the hadoop conf dir exists.
Maybe we can take the Role Command Order rules to handle this scenario.
But I still think creating the config dir is better if not existing the hdfs's config dir.
- zhangxiaolu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
-----------------------------------------------------------
On \u56db\u6708 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 10, 2017, 7:37 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
>
>
> Diff: https://reviews.apache.org/r/57451/diff/5/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20368.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
> On \u56db\u6708 12, 2017, 4:35 p.m., Alejandro Fernandez wrote:
> >
In the trunk,the relative code about hadoop_conf_dir has been removed,and there is no problem , and I will cancle this jira.
- zhangxiaolu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
-----------------------------------------------------------
On \u56db\u6708 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 10, 2017, 7:37 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
>
>
> Diff: https://reviews.apache.org/r/57451/diff/5/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20368.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57451: The Installation of hbase-client failed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Lines 67 (patched)
<https://reviews.apache.org/r/57451/#comment244764>
I've actually never seen this, so perhaps a more appropriate fix would be in HDFS Client instead.
HDFS Client itself should ensure that the hadoop conf dir exists.
- Alejandro Fernandez
On April 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 7:37 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
>
>
> Diff: https://reviews.apache.org/r/57451/diff/5/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20368.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
> On \u56db\u6708 11, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > <https://reviews.apache.org/r/57451/diff/5/?file=1686957#file1686957line67>
> >
> > I'm thinking more about this, what happens if Ambari Agent is running as non-root?
> >
> > Perhaps we should instead
> > 1. introduce Role Command Order rules to handle this scenario
> > OR
> > 2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf dir doesn't exist.
> >
> > I prefer option #2 since components should all be idempotent.
> >
> > How frequently does this happen? Is it only during UI, or BP installs?
>
> zhangxiaolu zhangxiaolu wrote:
> It happened frequently especially installing all services in first time?I hasn't tested it in BP.
And i'm confused if tried again three times and it would passed when installing all services in first time.
- zhangxiaolu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
-----------------------------------------------------------
On \u56db\u6708 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 10, 2017, 7:37 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
>
>
> Diff: https://reviews.apache.org/r/57451/diff/5/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20368.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
> On \u56db\u6708 11, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > <https://reviews.apache.org/r/57451/diff/5/?file=1686957#file1686957line67>
> >
> > I'm thinking more about this, what happens if Ambari Agent is running as non-root?
> >
> > Perhaps we should instead
> > 1. introduce Role Command Order rules to handle this scenario
> > OR
> > 2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf dir doesn't exist.
> >
> > I prefer option #2 since components should all be idempotent.
> >
> > How frequently does this happen? Is it only during UI, or BP installs?
It happened frequently especially installing all services in first time?I hasn't tested it in BP.
- zhangxiaolu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
-----------------------------------------------------------
On \u56db\u6708 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 10, 2017, 7:37 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
>
>
> Diff: https://reviews.apache.org/r/57451/diff/5/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20368.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57451: The Installation of hbase-client failed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Lines 67 (patched)
<https://reviews.apache.org/r/57451/#comment244549>
I'm thinking more about this, what happens if Ambari Agent is running as non-root?
Perhaps we should instead
1. introduce Role Command Order rules to handle this scenario
OR
2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf dir doesn't exist.
I prefer option #2 since components should all be idempotent.
How frequently does this happen? Is it only during UI, or BP installs?
- Alejandro Fernandez
On April 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 7:37 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
>
>
> Diff: https://reviews.apache.org/r/57451/diff/5/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20368.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
-----------------------------------------------------------
(Updated \u56db\u6708 10, 2017, 7:37 a.m.)
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368
Repository: ambari
Description
-------
The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
Diff: https://reviews.apache.org/r/57451/diff/5/
Changes: https://reviews.apache.org/r/57451/diff/4-5/
Testing
-------
done it
File Attachments
----------------
AMBARI-20368.patch
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
Thanks,
zhangxiaolu zhangxiaolu
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
-----------------------------------------------------------
(Updated \u56db\u6708 9, 2017, 6:40 a.m.)
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368
Repository: ambari
Description
-------
The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 9bb0dd7
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 60022e1
Diff: https://reviews.apache.org/r/57451/diff/4/
Changes: https://reviews.apache.org/r/57451/diff/3-4/
Testing
-------
done it
File Attachments
----------------
AMBARI-20368.patch
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
Thanks,
zhangxiaolu zhangxiaolu
Re: Review Request 57451: The Installation of hbase-client failed
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
-----------------------------------------------------------
(Updated \u56db\u6708 7, 2017, 11:05 p.m.)
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368
Repository: ambari
Description
-------
The problem is caused by the wrong installation order, which means hbase-client will be installed before the installation of hdfs-client. Under such circumstance, installation of hdfs-client will fail because the hadoop-conf-dir does not exist.
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when adding new host, therefore, in my opinion, the second choice would be more appropriate.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 8ad802e
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989
Diff: https://reviews.apache.org/r/57451/diff/3/
Changes: https://reviews.apache.org/r/57451/diff/2-3/
Testing
-------
done it
File Attachments
----------------
AMBARI-20368.patch
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
Thanks,
zhangxiaolu zhangxiaolu