You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/26 12:02:35 UTC

[GitHub] [maven-assembly-plugin] cstamas opened a new pull request, #55: Do not download whole universe

cstamas opened a new pull request, #55:
URL: https://github.com/apache/maven-assembly-plugin/pull/55

Problem: try to build maven master with empty repository,
you will notice that we get things from repository.sonatype.org
repository, that is wrong. Moreover, if you look carefully, you
will notice that we download/resolve totally unrelated things
to our build, like felix plugin etc. For fun, it downloads
Maven 2.2.0, Maven 2.0.7 etc as well.

Without PR:
https://gist.github.com/cstamas/badb32a25dbe444679774611f61d94b1

Reason: m-assembly-p "rebuilds" all the project of depSet to
get MavenProject instance of them and transitive deps, but alas,
it was doing it too eagerly: it was getting even plugins that
built our dependendencies, while we are really not want them.
So, instead to re-use the "project building request" of
currently built project, just create a simple PBR that is
tuned "just enough" to get results we want, nothing more.
We do not want the plugins that built our dependencies.

With PR:
https://gist.github.com/cstamas/1e9dfd0384dceda7a8195edfc1bfb61b

Following this checklist to help us incorporate your
contribution quickly and easily:

- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).

If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.

- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)

- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org