You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/09 17:48:32 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request #1741: mmcsd_sdio: Arm the write complete detection
davids5 opened a new pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741
## Summary
The Multiblock write path was missing the
the SDIO_WAITENABLE with SDIOWAIT_WRCOMPLETE.
This could be seen with debugging turned on as
mmcsd_eventwait: ERROR: Awakened with 10
mmcsd_transferready: ERROR: mmcsd_eventwait for transfer ready failed: -5
## Impact
Performance, and error messages under debug.
## Testing
master:
```
Insh> sd_bench
INFO [sd_bench] Using block size = 4096 bytes, sync=0
INFO [sd_bench]
INFO [sd_bench] Testing Sequential Write Speed...
INFO [sd_bench] Run 0: 1860.04 KB/s, max write time: 66 ms (= 60.61 KB/s), fsync: 15 ms
INFO [sd_bench] Run 1: 2544.74 KB/s, max write time: 20 ms (= 200.00 KB/s), fsync: 4 ms
INFO [sd_bench] Run 2: 1402.85 KB/s, max write time: 22 ms (= 181.82 KB/s), fsync: 4 ms
INFO [sd_bench] Run 3: 2719.82 KB/s, max write time: 35 ms (= 114.29 KB/s), fsync: 4 ms
INFO [sd_bench] Run 4: 2581.84 KB/s, max write time: 24 ms (= 166.67 KB/s), fsync: 3 ms
INFO [sd_bench] Avg : 2221.40 KB/s
```
With this PR:
```
nsh> sd_bench
INFO [sd_bench] Using block size = 4096 bytes, sync=0
INFO [sd_bench]
INFO [sd_bench] Testing Sequential Write Speed...
INFO [sd_bench] Run 0: 2788.61 KB/s, max write time: 9 ms (= 444.44 KB/s), fsync: 4 ms
INFO [sd_bench] Run 1: 2813.93 KB/s, max write time: 6 ms (= 666.67 KB/s), fsync: 6 ms
INFO [sd_bench] Run 2: 2795.05 KB/s, max write time: 6 ms (= 666.67 KB/s), fsync: 4 ms
INFO [sd_bench] Run 3: 1719.35 KB/s, max write time: 23 ms (= 173.91 KB/s), fsync: 3 ms
INFO [sd_bench] Run 4: 2508.10 KB/s, max write time: 142 ms (= 28.17 KB/s), fsync: 4 ms
INFO [sd_bench] Avg : 2525.04 KB/s
n
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1741: mmcsd_sdio: Arm the write complete detection
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1741: mmcsd_sdio: Arm the write complete detection
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741#issuecomment-690288921
@xiaoxiang781216 - Please merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1741: mmcsd_sdio: Arm the write complete detection
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741#issuecomment-690244048
> Looks to me like a bug on GitHub side since that bundle was 173MB uploaded in Fetch Source but it only download 22B. I think we can just ignore this. I probably am also going to remove the cache for moving code between phases of the build because the new changes GitHub put in place means we almost always miss and fall back on the artifact mode for passing the data.
I see. Thank you @btashton!
Since this passed would you please merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1741: mmcsd_sdio: Arm the write complete detection
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741#issuecomment-690210340
> > @davids5 sorry I don't see the failure even in old runs. If you can link the run I can look, but that would indicate it never built the source bundle which does not make sense.
>
> Hi @btashton !
>
> Thank you for looking at it. https://github.com/apache/incubator-nuttx/runs/1095870401
Upload:
```
Received 181337179 of 181337179 (100.0%), 154.1 MBs/sec
6Cache Size: ~173 MB (181337179 B)
7/bin/tar --use-compress-program zstd -d -xf /home/runner/work/_temp/59adc9d8-123f-46d8-88bb-b79ddb08d3c7/cache.tzst -P -C /home/runner/work/incubator-nuttx/incubator-nuttx
8Cache restored from key: build-sources-246738878
```
Download:
```
Run actions/cache@v2
7Received 22 of 22 (100.0%), 0.0 MBs/sec
8Cache Size: ~0 MB (22 B)
9/bin/tar --use-compress-program zstd -d -xf /home/runner/work/_temp/90c60d88-9985-4795-83c7-9b71f9d94915/cache.tzst -P -C /home/runner/work/incubator-nuttx/incubator-nuttx
10Cache restored from key: build-sources-246738878
```
Looks to me like a bug on GitHub side since that bundle was 173MB uploaded in Fetch Source but it only download 22B. I think we can just ignore this. I probably am also going to remove the cache for moving code between phases of the build because the new changes GitHub put in place means we almost always miss and fall back on the artifact mode for passing the data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1741: mmcsd_sdio: Arm the write complete detection
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741#issuecomment-690198456
> @davids5 sorry I don't see the failure even in old runs. If you can link the run I can look, but that would indicate it never built the source bundle which does not make sense.
Hi @btashton !
Thank you for looking at it. https://github.com/apache/incubator-nuttx/runs/1095870401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1741: mmcsd_sdio: Arm the write complete detection
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741#issuecomment-690146349
@btashton On the initial push I had
any idea what caused this and how I can avoid it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1741: mmcsd_sdio: Arm the write complete detection
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741#issuecomment-690153169
@davids5 sorry I don't see the failure even in old runs. If you can link the run I can look, but that would indicate it never built the source bundle which does not make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org