[GitHub] [solr] epugh commented on a diff in pull request #1149: SOLR-16498: Tests to retrieve url from SolrClient

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1009412874


##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -3235,6 +3236,14 @@ private static boolean isChildDoc(Object o) {
     return o instanceof SolrInputDocument;
   }
 
+  public static String getUrlFrom(SolrClient solrClient) {
+    if (solrClient instanceof HttpSolrClient) {

Review Comment:
   I imagine we would want to check instaceof for other clients too?   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org