You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2012/09/21 16:15:08 UTC
[jira] [Created] (DERBY-5935) Remove unused code for factory
classes in the reflection service
Knut Anders Hatlen created DERBY-5935:
-----------------------------------------
Summary: Remove unused code for factory classes in the reflection service
Key: DERBY-5935
URL: https://issues.apache.org/jira/browse/DERBY-5935
Project: Derby
Issue Type: Improvement
Components: Services
Affects Versions: 10.10.0.0
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Priority: Minor
The reflection service has some code for creating factory classes for each class generated for SQL queries, but the code is disabled due to memory concerns. We should remove the code to reduce code complexity and engine jar footprint. If someone wants to enable this code later, they can always revive it from the svn history.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5935) Remove unused code for factory
classes in the reflection service
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5935:
--------------------------------------
Issue & fix info: Patch Available
> Remove unused code for factory classes in the reflection service
> ----------------------------------------------------------------
>
> Key: DERBY-5935
> URL: https://issues.apache.org/jira/browse/DERBY-5935
> Project: Derby
> Issue Type: Improvement
> Components: Services
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5935-1a.diff
>
>
> The reflection service has some code for creating factory classes for each class generated for SQL queries, but the code is disabled due to memory concerns. We should remove the code to reduce code complexity and engine jar footprint. If someone wants to enable this code later, they can always revive it from the svn history.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5935) Remove unused code for factory classes
in the reflection service
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-5935.
-------------------------------------
Resolution: Fixed
Fix Version/s: 10.10.0.0
Issue & fix info: (was: Patch Available)
Committed revision 1390342.
> Remove unused code for factory classes in the reflection service
> ----------------------------------------------------------------
>
> Key: DERBY-5935
> URL: https://issues.apache.org/jira/browse/DERBY-5935
> Project: Derby
> Issue Type: Improvement
> Components: Services
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.10.0.0
>
> Attachments: d5935-1a.diff
>
>
> The reflection service has some code for creating factory classes for each class generated for SQL queries, but the code is disabled due to memory concerns. We should remove the code to reduce code complexity and engine jar footprint. If someone wants to enable this code later, they can always revive it from the svn history.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5935) Remove unused code for factory
classes in the reflection service
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5935:
--------------------------------------
Attachment: d5935-1a.diff
Attaching the patch d5935-1a.diff which makes the following changes:
ReflectGeneratedClass.java:
- Removed third parameter to constructor (factoryClass) since it's always null.
- Removed fields factoryClass and factory because they are always null when constructor is called with param factoryClass=null.
- Removed method newInstance() because it always degenerates to a call to super.newInstance() when factoryClass=null, so it could just inherit the method from the parent class.
ReflectLoader2.java:
- Remove third argument from call to ReflectGeneratedClass's constructor.
- Remove commented out code for generating factory classes.
ReflectClassesJava2.java:
- Remove third argument from call to ReflectGeneratedClass's constructor.
DatabaseClasses.java:
- Remove code that's only called by the commented out code in ReflectLoader2.
GCInstanceFactory.java:
- Removed the class since it's only used in code removed by this patch.
All the regression tests ran cleanly with the patch.
> Remove unused code for factory classes in the reflection service
> ----------------------------------------------------------------
>
> Key: DERBY-5935
> URL: https://issues.apache.org/jira/browse/DERBY-5935
> Project: Derby
> Issue Type: Improvement
> Components: Services
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5935-1a.diff
>
>
> The reflection service has some code for creating factory classes for each class generated for SQL queries, but the code is disabled due to memory concerns. We should remove the code to reduce code complexity and engine jar footprint. If someone wants to enable this code later, they can always revive it from the svn history.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira