You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Dmitriy Pavlov <dp...@apache.org> on 2019/08/08 20:51:47 UTC
Ignite commits atomicity & GG tickets
Hi Igniters,
I little bit upset because I sometimes find GG tickets mentioned in Ignite
source code as a reason for Ignoring tests, todos, etc.
I am personally grateful to all GG's employes for contributing to Ignite
code base.
I just want to some accuracy for commits provided to Ignite community, it
should contain ONLY tickets which is available to all members.
Do you find the presence of GG's tickets in the commit is a reason for
revert?
Sincerely,
Dmitriy Pavlov
Re: Ignite commits atomicity & GG tickets
Posted by Dmitriy Pavlov <dp...@apache.org>.
Ok, thank you.
I forgot to mention atomicity. I discourage contributors from so-called
bulk commits when several unrelated changes are merged into one commit. In
case of any issues, it is not possible to find out reasons why it was
changed, it is not possible to easily revert.
чт, 8 авг. 2019 г. в 23:58, Denis Magda <dm...@apache.org>:
> >
> > Do you find the presence of GG's tickets in the commit is a reason for
> > revert?
>
>
> No, GG employees just need to follow "commit messages" guidelines removing
> GG-specific details from the messages.
>
>
>
> -
> Denis
>
>
> On Thu, Aug 8, 2019 at 1:52 PM Dmitriy Pavlov <dp...@apache.org> wrote:
>
> > Hi Igniters,
> >
> > I little bit upset because I sometimes find GG tickets mentioned in
> Ignite
> > source code as a reason for Ignoring tests, todos, etc.
> >
> > I am personally grateful to all GG's employes for contributing to Ignite
> > code base.
> >
> > I just want to some accuracy for commits provided to Ignite community, it
> > should contain ONLY tickets which is available to all members.
> >
> > Do you find the presence of GG's tickets in the commit is a reason for
> > revert?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
>
Re: Ignite commits atomicity & GG tickets
Posted by Denis Magda <dm...@apache.org>.
>
> Do you find the presence of GG's tickets in the commit is a reason for
> revert?
No, GG employees just need to follow "commit messages" guidelines removing
GG-specific details from the messages.
-
Denis
On Thu, Aug 8, 2019 at 1:52 PM Dmitriy Pavlov <dp...@apache.org> wrote:
> Hi Igniters,
>
> I little bit upset because I sometimes find GG tickets mentioned in Ignite
> source code as a reason for Ignoring tests, todos, etc.
>
> I am personally grateful to all GG's employes for contributing to Ignite
> code base.
>
> I just want to some accuracy for commits provided to Ignite community, it
> should contain ONLY tickets which is available to all members.
>
> Do you find the presence of GG's tickets in the commit is a reason for
> revert?
>
> Sincerely,
> Dmitriy Pavlov
>