You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rob Hartill <ro...@imdb.com> on 1997/07/12 11:06:45 UTC
Re: Chunking Error (fwd)
After checking with Roy, I think we need the following fix to the
recently added "DONE" feature..
Index: http_request.c
===================================================================
RCS file: /imdb/cvs/apache/src/http_request.c,v
retrieving revision 1.21
diff -u -r1.21 http_request.c
--- http_request.c 1997/07/09 17:31:15 1.21
+++ http_request.c 1997/07/12 09:04:14
@@ -788,8 +788,11 @@
char *custom_response = response_code_string(r, error_index);
int recursive_error = 0;
- if (type == DONE) return;
-
+ if (type == DONE) {
+ finalize_request_protocol(r);
+ return;
+ }
+
/* The following takes care of Apache redirects to custom response URLs
* Note that if we are already dealing with the response to some other
* error condition, we just report on the original error, and give up on
---------- Forwarded message ----------
Date: Thu, 10 Jul 1997 21:55:10 -0700
From: "Roy T. Fielding" <fi...@kiwi.ics.uci.edu>
To: Yaron Goland <ya...@microsoft.com>
Cc: "'robh@imdb.com'" <ro...@imdb.com>,
Arthur Bierer <ar...@microsoft.com>
Subject: Re: Chunking Error
>Greetings, the imdb server does not send the terminating zero chunk at
>the end of its HTTP/1.1 transmissions from http://us.imdb.com/M/ballot.
>This makes HTTP/1.1 clients, such as the upcoming beta of Internet
>Explorer 4.0, unhappy. Your server self reports as Apache/1.3-dev
>mod_perl/1.00b1.
> Thanks,
> Yaron (HTTP/1.1 compliance patrol)
> PM for Internet Protocols, WinInet, DAV, etc. etc. etc.
That is Rob's denial of service weenie local to IMDB -- it is not in the
distributed Apache server.
Rob, when you short-circuit a response, the module must call
finalize_request_protocol(r)
after sending the body.
....Roy
Re: Chunking Error (fwd)
Posted by Dean Gaudet <dg...@arctic.org>.
Speaking of chunking problems -- Sameer's cgi patch messes up chunking.
At least I think it does... I haven't been around a machine enough in the
past few days. It's arguable that the bug is in buff.c rather than
sameer's code. In any event I'll fix it.
Dean
On Sat, 12 Jul 1997, Rob Hartill wrote:
>
> After checking with Roy, I think we need the following fix to the
> recently added "DONE" feature..
>
> Index: http_request.c
> ===================================================================
> RCS file: /imdb/cvs/apache/src/http_request.c,v
> retrieving revision 1.21
> diff -u -r1.21 http_request.c
> --- http_request.c 1997/07/09 17:31:15 1.21
> +++ http_request.c 1997/07/12 09:04:14
> @@ -788,8 +788,11 @@
> char *custom_response = response_code_string(r, error_index);
> int recursive_error = 0;
>
> - if (type == DONE) return;
> -
> + if (type == DONE) {
> + finalize_request_protocol(r);
> + return;
> + }
> +
> /* The following takes care of Apache redirects to custom response URLs
> * Note that if we are already dealing with the response to some other
> * error condition, we just report on the original error, and give up on
>
>
> ---------- Forwarded message ----------
> Date: Thu, 10 Jul 1997 21:55:10 -0700
> From: "Roy T. Fielding" <fi...@kiwi.ics.uci.edu>
> To: Yaron Goland <ya...@microsoft.com>
> Cc: "'robh@imdb.com'" <ro...@imdb.com>,
> Arthur Bierer <ar...@microsoft.com>
> Subject: Re: Chunking Error
>
> >Greetings, the imdb server does not send the terminating zero chunk at
> >the end of its HTTP/1.1 transmissions from http://us.imdb.com/M/ballot.
> >This makes HTTP/1.1 clients, such as the upcoming beta of Internet
> >Explorer 4.0, unhappy. Your server self reports as Apache/1.3-dev
> >mod_perl/1.00b1.
> > Thanks,
> > Yaron (HTTP/1.1 compliance patrol)
> > PM for Internet Protocols, WinInet, DAV, etc. etc. etc.
>
> That is Rob's denial of service weenie local to IMDB -- it is not in the
> distributed Apache server.
>
> Rob, when you short-circuit a response, the module must call
>
> finalize_request_protocol(r)
>
> after sending the body.
>
> ....Roy
>
>