[GitHub] [flink] snuyanzin commented on a diff in pull request #20663: [FLINK-29067][Table SQL/API] Replace deprecated SqlParser#configBuilder with SqlParser#config

[GitBox <gi...@apache.org>]

snuyanzin commented on code in PR #20663:
URL: https://github.com/apache/flink/pull/20663#discussion_r962884567


##########
flink-table/flink-sql-parser-hive/src/main/java/org/apache/flink/sql/parser/hive/package-info.java:
##########
@@ -26,14 +26,13 @@
  * <blockquote>
  *
  * <pre>
- *   SqlParser.create(source,
- *   		SqlParser.configBuilder()
- *   			.setParserFactory(new FlinkSqlParserImplFactory(conformance0))
- * 				.setQuoting(Quoting.DOUBLE_QUOTE)
- * 				.setUnquotedCasing(Casing.TO_UPPER)
- * 				.setQuotedCasing(Casing.UNCHANGED)
- * 				.setConformance(conformance0) // the sql conformance you want use.
- * 				.build());
+ * SqlParser.create(source,
+ * SqlParser.config()
+ * .withParserFactory(new FlinkSqlParserImplFactory(conformance0))
+ * .withQuoting(Quoting.DOUBLE_QUOTE)
+ * .withUnquotedCasing(Casing.TO_UPPER)
+ * .withQuotedCasing(Casing.UNCHANGED)
+ * .withConformance(conformance0); // the sql conformance you want use.

Review Comment:
   nice catch, thanks
   done
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org