You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/01/31 15:22:00 UTC
(commons-jelly) branch master updated: Remove useless inline comments
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jelly.git
The following commit(s) were added to refs/heads/master by this push:
new f35fa927 Remove useless inline comments
f35fa927 is described below
commit f35fa92772d9e598cc3347f431da7e619a6ccfba
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Jan 31 10:21:54 2024 -0500
Remove useless inline comments
---
.../commons/jelly/tags/ant/GrantProject.java | 12 ----------
.../org/apache/commons/digester/rss/Channel.java | 8 -------
.../org/apache/commons/digester/rss/Image.java | 8 -------
.../java/org/apache/commons/digester/rss/Item.java | 8 -------
.../apache/commons/digester/rss/RSSDigester.java | 28 ----------------------
.../org/apache/commons/digester/rss/TextInput.java | 8 -------
.../jelly/tags/jetty/JettyHttpServerTag.java | 5 ----
.../jelly/tags/jetty/SecurityHandlerTag.java | 4 ++--
.../commons/jelly/tags/quartz/CronTriggerTag.java | 11 ---------
.../apache/commons/jelly/tags/quartz/JellyJob.java | 8 -------
.../apache/commons/jelly/tags/quartz/JobTag.java | 12 ----------
.../commons/jelly/tags/quartz/TriggerTag.java | 4 ----
.../jelly/tags/quartz/WaitForSchedulerTag.java | 8 -------
.../commons/jelly/tags/swing/ConstraintTag.java | 6 +----
.../commons/jelly/tags/velocity/MergeTag.java | 4 ----
15 files changed, 3 insertions(+), 131 deletions(-)
diff --git a/jelly-tags/ant/src/main/java/org/apache/commons/jelly/tags/ant/GrantProject.java b/jelly-tags/ant/src/main/java/org/apache/commons/jelly/tags/ant/GrantProject.java
index 9052f49a..1fbddc6a 100644
--- a/jelly-tags/ant/src/main/java/org/apache/commons/jelly/tags/ant/GrantProject.java
+++ b/jelly-tags/ant/src/main/java/org/apache/commons/jelly/tags/ant/GrantProject.java
@@ -38,17 +38,9 @@ import org.apache.tools.ant.ProjectHelper;
*/
public class GrantProject extends Project {
- // ------------------------------------------------------------
- // Instance members
- // ------------------------------------------------------------
-
/** Properties delegate. */
private PropsHandler propsHandler;
- // ------------------------------------------------------------
- // Constructors
- // ------------------------------------------------------------
-
/** Constructs a new, empty <code>GrantProject</code>.
*
* <p>
@@ -62,10 +54,6 @@ public class GrantProject extends Project {
this.propsHandler = null;
}
- // ------------------------------------------------------------
- // Instance methods
- // ------------------------------------------------------------
-
/** Install a <code>PropsHandler</code> delegate.
*
* @param propsHandler The <code>PropsHandler</code> to install,
diff --git a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Channel.java b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Channel.java
index 3bc32018..ab1d0ffd 100644
--- a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Channel.java
+++ b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Channel.java
@@ -35,10 +35,6 @@ import java.util.ArrayList;
public class Channel implements Serializable {
-
- // ----------------------------------------------------- Instance Variables
-
-
/**
* The set of items associated with this Channel.
*/
@@ -56,10 +52,6 @@ public class Channel implements Serializable {
*/
protected ArrayList skipHours = new ArrayList();
-
- // ------------------------------------------------------------- Properties
-
-
/**
* The channel copyright (1-100 characters).
*/
diff --git a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Image.java b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Image.java
index c58f558c..2efb73d5 100644
--- a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Image.java
+++ b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Image.java
@@ -30,10 +30,6 @@ import java.io.Serializable;
public class Image implements Serializable {
-
- // ------------------------------------------------------------- Properties
-
-
/**
* The image description (1-100 characters).
*/
@@ -117,10 +113,6 @@ public class Image implements Serializable {
this.width = width;
}
-
- // -------------------------------------------------------- Package Methods
-
-
/**
* Render this channel as XML conforming to the RSS 0.91 specification,
* to the specified writer.
diff --git a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Item.java b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Item.java
index 073d2b97..a5a899e9 100644
--- a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Item.java
+++ b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/Item.java
@@ -30,10 +30,6 @@ import java.io.Serializable;
public class Item implements Serializable {
-
- // ------------------------------------------------------------- Properties
-
-
/**
* The item description (1-500 characters).
*/
@@ -75,10 +71,6 @@ public class Item implements Serializable {
this.title = title;
}
-
- // -------------------------------------------------------- Package Methods
-
-
/**
* Render this channel as XML conforming to the RSS 0.91 specification,
* to the specified writer.
diff --git a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/RSSDigester.java b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/RSSDigester.java
index 003a82d9..47796f96 100644
--- a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/RSSDigester.java
+++ b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/RSSDigester.java
@@ -46,14 +46,6 @@ import org.xml.sax.SAXException;
public class RSSDigester extends Digester {
-
- // ----------------------------------------------------------- Constructors
-
-
-
- // ----------------------------------------------------- Instance Variables
-
-
/**
* Have we been configured yet?
*/
@@ -71,10 +63,6 @@ public class RSSDigester extends Digester {
"/org/apache/commons/digester/rss/rss-0.91.dtd",
};
-
- // ------------------------------------------------------------- Properties
-
-
/**
* The fully qualified class name of the <code>Channel</code>
* implementation class.
@@ -135,10 +123,6 @@ public class RSSDigester extends Digester {
this.textInputClass = textInputClass;
}
-
- // --------------------------------------------------------- Public Methods
-
-
/**
* Parse the content of the specified file using this Digester. Returns
* the root element from the object stack (which will be the Channel).
@@ -213,14 +197,6 @@ public class RSSDigester extends Digester {
}
-
- // -------------------------------------------------------- Package Methods
-
-
-
- // ------------------------------------------------------ Protected Methods
-
-
/**
* Configure the parsing rules that will be used to process RSS input.
*/
@@ -293,10 +269,6 @@ public class RSSDigester extends Digester {
}
-
- // ------------------------------------------------------ Test Main Program
-
-
/**
* Test main program that parses the channel description included in this
* package as a static resource.
diff --git a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/TextInput.java b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/TextInput.java
index 40846bf4..87a07395 100644
--- a/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/TextInput.java
+++ b/jelly-tags/betwixt/src/test/java/org/apache/commons/digester/rss/TextInput.java
@@ -30,10 +30,6 @@ import java.io.Serializable;
public class TextInput implements Serializable {
-
- // ------------------------------------------------------------- Properties
-
-
/**
* The text input description (1-100 characters).
*/
@@ -89,10 +85,6 @@ public class TextInput implements Serializable {
this.title = title;
}
-
- // -------------------------------------------------------- Package Methods
-
-
/**
* Render this channel as XML conforming to the RSS 0.91 specification,
* to the specified writer.
diff --git a/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/JettyHttpServerTag.java b/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/JettyHttpServerTag.java
index 32026ac5..9a93b033 100644
--- a/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/JettyHttpServerTag.java
+++ b/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/JettyHttpServerTag.java
@@ -196,7 +196,6 @@ public class JettyHttpServerTag extends TagSupport {
_server.addContext(context);
}
- /* ------------------------------------------------------------ */
/**
* Add a user authentication realm to the server instance
*
@@ -208,10 +207,6 @@ public class JettyHttpServerTag extends TagSupport {
return _server.addRealm(realm);
}
- //--------------------------------------------------------------------------
- // Property accessors/mutators
- //--------------------------------------------------------------------------
-
/**
* Getter for property var.
*
diff --git a/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java b/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java
index dc591707..6b6656b8 100644
--- a/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java
+++ b/jelly-tags/jetty/src/main/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java
@@ -147,7 +147,7 @@ public class SecurityHandlerTag extends TagSupport {
}
- /* ------------------------------------------------------------
+ /*
* This is the code from Jetty's WebApplicationContext
* with the HttpContextTag parameter added
*
@@ -217,7 +217,7 @@ public class SecurityHandlerTag extends TagSupport {
}
}
- /* ------------------------------------------------------------
+ /*
* This is the code from Jetty's WebApplicationContext
* with the HttpContextTag parameter added
*
diff --git a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/CronTriggerTag.java b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/CronTriggerTag.java
index b90ad278..f9e85dad 100644
--- a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/CronTriggerTag.java
+++ b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/CronTriggerTag.java
@@ -35,10 +35,6 @@ import java.util.Date;
*/
public class CronTriggerTag extends QuartzTagSupport
{
- // ------------------------------------------------------------
- // Instance members
- // ------------------------------------------------------------
-
/** Cron time spec. */
private String spec;
@@ -54,10 +50,6 @@ public class CronTriggerTag extends QuartzTagSupport
/** Job group. */
private String jobGroup;
- // ------------------------------------------------------------
- // COnstructors
- // ------------------------------------------------------------
-
/** Construct.
*/
public CronTriggerTag()
@@ -65,9 +57,6 @@ public class CronTriggerTag extends QuartzTagSupport
// intentionally left blank.
}
- // ------------------------------------------------------------
- // ------------------------------------------------------------
-
/** Sets the name.
*
* @param name.
diff --git a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JellyJob.java b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JellyJob.java
index 61105312..ca708256 100644
--- a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JellyJob.java
+++ b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JellyJob.java
@@ -33,10 +33,6 @@ import org.quartz.JobExecutionException;
*/
public class JellyJob implements Job
{
- // ------------------------------------------------------------
- // Constructors
- // ------------------------------------------------------------
-
/** Construct.
*/
public JellyJob()
@@ -44,10 +40,6 @@ public class JellyJob implements Job
// intentionally left blank.
}
- // ------------------------------------------------------------
- // Instance methods
- // ------------------------------------------------------------
-
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// org.quartz.Job
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
diff --git a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JobTag.java b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JobTag.java
index 684bbdb7..093688fa 100644
--- a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JobTag.java
+++ b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/JobTag.java
@@ -32,20 +32,12 @@ import org.quartz.JobDataMap;
*/
public class JobTag extends QuartzTagSupport
{
- // ------------------------------------------------------------
- // Instance members
- // ------------------------------------------------------------
-
/** Group of the job. */
private String group;
/** Name of the job. */
private String name;
- // ------------------------------------------------------------
- // Constructors
- // ------------------------------------------------------------
-
/** Construct.
*/
public JobTag()
@@ -53,10 +45,6 @@ public class JobTag extends QuartzTagSupport
// intentionally left blank.
}
- // ------------------------------------------------------------
- // Instance methods
- // ------------------------------------------------------------
-
/** Sets the name of this job.
*
* @param name The name of this job.
diff --git a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/TriggerTag.java b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/TriggerTag.java
index 41f25aa6..c187f9ad 100644
--- a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/TriggerTag.java
+++ b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/TriggerTag.java
@@ -23,10 +23,6 @@ package org.apache.commons.jelly.tags.quartz;
*/
public abstract class TriggerTag extends QuartzTagSupport
{
- // ------------------------------------------------------------
- // Constructors
- // ------------------------------------------------------------
-
/** Construct.
*/
protected TriggerTag()
diff --git a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/WaitForSchedulerTag.java b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/WaitForSchedulerTag.java
index 18616826..3f247d59 100644
--- a/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/WaitForSchedulerTag.java
+++ b/jelly-tags/quartz/src/main/java/org/apache/commons/jelly/tags/quartz/WaitForSchedulerTag.java
@@ -30,10 +30,6 @@ import org.quartz.SchedulerException;
*/
public class WaitForSchedulerTag extends QuartzTagSupport
{
- // ------------------------------------------------------------
- // Constructors
- // ------------------------------------------------------------
-
/** Construct.
*/
public WaitForSchedulerTag()
@@ -41,10 +37,6 @@ public class WaitForSchedulerTag extends QuartzTagSupport
// intentionally left blank.
}
- // ------------------------------------------------------------
- // Instance methods
- // ------------------------------------------------------------
-
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// org.apache.commons.jelly.Tag
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
diff --git a/jelly-tags/swing/src/main/java/org/apache/commons/jelly/tags/swing/ConstraintTag.java b/jelly-tags/swing/src/main/java/org/apache/commons/jelly/tags/swing/ConstraintTag.java
index 9fabbb05..4928f554 100644
--- a/jelly-tags/swing/src/main/java/org/apache/commons/jelly/tags/swing/ConstraintTag.java
+++ b/jelly-tags/swing/src/main/java/org/apache/commons/jelly/tags/swing/ConstraintTag.java
@@ -88,8 +88,6 @@ public class ConstraintTag extends DynaBeanTagSupport {
bean = factory.newInstance();
}
- // --------------------------------------------- ATTRIBUTES
-
@Override
public void beforeSetAttributes ( ) throws JellyTagException {
try {
@@ -117,7 +115,6 @@ public class ConstraintTag extends DynaBeanTagSupport {
}
}
-// --------------------------------------------------
/** Children invocation... just nothing...
*/
@Override
@@ -127,7 +124,6 @@ public class ConstraintTag extends DynaBeanTagSupport {
// nothing else to do... the getConstraintObject method should have been called.
}
- // ----------------------------------------------
public Object getBean() {
return bean;
}
@@ -137,4 +133,4 @@ public class ConstraintTag extends DynaBeanTagSupport {
public Object getConstraintObject() {
return getBean();
}
-} // class ConstraintTag
+}
diff --git a/jelly-tags/velocity/src/main/java/org/apache/commons/jelly/tags/velocity/MergeTag.java b/jelly-tags/velocity/src/main/java/org/apache/commons/jelly/tags/velocity/MergeTag.java
index 241e9ae5..3b21d7f0 100644
--- a/jelly-tags/velocity/src/main/java/org/apache/commons/jelly/tags/velocity/MergeTag.java
+++ b/jelly-tags/velocity/src/main/java/org/apache/commons/jelly/tags/velocity/MergeTag.java
@@ -48,8 +48,6 @@ public class MergeTag extends VelocityTagSupport
private String outputEncoding;
private boolean readOnly = true;
- // -- Tag interface -----------------------------------------------------
-
@Override
public void doTag( final XMLOutput output ) throws JellyTagException
{
@@ -85,8 +83,6 @@ public class MergeTag extends VelocityTagSupport
}
}
- // -- Properties --------------------------------------------------------
-
/**
* Sets the var used to store the results of the merge.
*