You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/10/12 12:16:01 UTC

[GitHub] [calcite] zabetak commented on a change in pull request #2208: [CALCITE-4333] The Sort rel should be decorrelated even though it has…

zabetak commented on a change in pull request #2208:
URL: https://github.com/apache/calcite/pull/2208#discussion_r503254426



##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -680,6 +677,17 @@ private static void shiftMapping(Map<Integer, Integer> mapping, int startIndex,
 
   public Frame getInvoke(RelNode r, RelNode parent) {
     final Frame frame = dispatcher.invoke(r);
+    if (frame != null && parent instanceof Correlate && r instanceof Sort) {

Review comment:
       Does this code check only the parent or any ancestor? Is it valid to check only the parent?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org