You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by ThilinaManamgoda <gi...@git.apache.org> on 2016/06/01 19:09:52 UTC
[GitHub] incubator-taverna-common-activities pull request #4: Cwl browse
GitHub user ThilinaManamgoda opened a pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/4
Cwl browse
This is first week progress
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThilinaManamgoda/incubator-taverna-common-activities cwl-browse
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-common-activities/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit e9b7d21c6791315c4097acf3ba8f8afbc7471979
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-05-24T12:14:47Z
add new bundle for ui
commit 6f71070041605beec6e5c67a3415e11880c7324d
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-05-25T23:51:09Z
Testing cwl reader and created cwlserviceprovider,cwlservicedes,cwlconfigurationbean
commit 6bb504ed588e0627f1b5b8ebf504ef50d830caec
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-05-28T11:57:58Z
dependency problem resolved
commit 18c5155f380bc1e6e7d92b5b9dcadacff6f9da13
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-05-28T21:53:35Z
add a method that vallidate the cwl tool for Taverna
commit c00353b777c506e61db5c0c5c8d6d720dd82ef78
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-01T18:06:54Z
modified processinputs method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-common-activities pull request #4: Cwl browse
Posted by stain <gi...@git.apache.org>.
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/4#discussion_r65908799
--- Diff: taverna-cwl-activity-ui/src/test/java/org/apache/taverna/cwl/ui/TestWorkBench.java ---
@@ -0,0 +1,11 @@
+package org.apache.taverna.cwl.ui;
--- End diff --
and here..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-taverna-common-activities issue #4: Cwl browse
Posted by Thilina Manamgoda <ma...@gmail.com>.
Hi,
So what is next step ? . i little confused about what do next .
regards,
Thilina.
On Mon, Jun 6, 2016 at 7:12 PM, Thilina Manamgoda <ma...@gmail.com>
wrote:
> are cropping,resizing considered as modifying
>
> On Mon, Jun 6, 2016 at 7:11 PM, Thilina Manamgoda <ma...@gmail.com>
> wrote:
>
>> i just removed it and pushed it again
>>
>>
>> On Mon, Jun 6, 2016 at 7:09 PM, stain <gi...@git.apache.org> wrote:
>>
>>> Github user stain commented on the issue:
>>>
>>> https://github.com/apache/incubator-taverna-common-activities/pull/4
>>>
>>> Ah now, the CC SA for unmodifiable binaries, so OK as long as we
>>> don't modify the CWL logo.
>>> http://www.apache.org/legal/resolved.html#cc-sa
>>>
>>> We just need to add that copyright statement to our NOTICE.
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and have
>>> your
>>> reply appear on GitHub as well. If your project does not have this
>>> feature
>>> enabled and wishes so, or if the feature is enabled but not working,
>>> please
>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>> ticket
>>> with INFRA.
>>> ---
>>>
>>
>>
>
Re: [GitHub] incubator-taverna-common-activities issue #4: Cwl browse
Posted by Thilina Manamgoda <ma...@gmail.com>.
are cropping,resizing considered as modifying
On Mon, Jun 6, 2016 at 7:11 PM, Thilina Manamgoda <ma...@gmail.com>
wrote:
> i just removed it and pushed it again
>
>
> On Mon, Jun 6, 2016 at 7:09 PM, stain <gi...@git.apache.org> wrote:
>
>> Github user stain commented on the issue:
>>
>> https://github.com/apache/incubator-taverna-common-activities/pull/4
>>
>> Ah now, the CC SA for unmodifiable binaries, so OK as long as we
>> don't modify the CWL logo.
>> http://www.apache.org/legal/resolved.html#cc-sa
>>
>> We just need to add that copyright statement to our NOTICE.
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
Re: [GitHub] incubator-taverna-common-activities issue #4: Cwl browse
Posted by Thilina Manamgoda <ma...@gmail.com>.
i just removed it and pushed it again
On Mon, Jun 6, 2016 at 7:09 PM, stain <gi...@git.apache.org> wrote:
> Github user stain commented on the issue:
>
> https://github.com/apache/incubator-taverna-common-activities/pull/4
>
> Ah now, the CC SA for unmodifiable binaries, so OK as long as we don't
> modify the CWL logo.
> http://www.apache.org/legal/resolved.html#cc-sa
>
> We just need to add that copyright statement to our NOTICE.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-taverna-common-activities issue #4: Cwl browse
Posted by stain <gi...@git.apache.org>.
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/4
Ah now, the CC SA for unmodifiable binaries, so OK as long as we don't modify the CWL logo.
http://www.apache.org/legal/resolved.html#cc-sa
We just need to add that copyright statement to our NOTICE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-common-activities pull request #4: Cwl browse
Posted by stain <gi...@git.apache.org>.
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/4#discussion_r65908687
--- Diff: taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProviderConfig.java ---
@@ -0,0 +1,25 @@
+package org.apache.taverna.cwl.ui.serviceprovider;
--- End diff --
Could you add a license header also here? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-common-activities pull request #4: Cwl browse
Posted by ThilinaManamgoda <gi...@git.apache.org>.
Github user ThilinaManamgoda commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/4#discussion_r65910784
--- Diff: taverna-cwl-activity-ui/src/test/java/org/apache/taverna/cwl/ui/TestWorkBench.java ---
@@ -0,0 +1,11 @@
+package org.apache.taverna.cwl.ui;
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-common-activities pull request #4: Cwl browse
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-taverna-common-activities/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-common-activities issue #4: Cwl browse
Posted by stain <gi...@git.apache.org>.
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/4
Thank you! Merged into `cwl-browse` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-common-activities issue #4: Cwl browse
Posted by stain <gi...@git.apache.org>.
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/4
Looks good! You are adding cwl-logo-header.png, which has an [incompatible license](https://github.com/common-workflow-language/logo/blob/master/LICENSE.md).
Could you remove that, and I'll raise with CWL to change the license.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---