You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/05/03 23:48:30 UTC
[kudu-CR] preflight: add checks for openssl and zlib
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10304
to review the following change.
Change subject: preflight: add checks for openssl and zlib
......................................................................
preflight: add checks for openssl and zlib
The openssl devel package is required for Kudu, but also for squeasel, so
we should check for its existence in preflight.py.
Same goes for the zlib devel package, which is also required by IWYU.
Change-Id: Ib9bd33ab489d742e9cdfc9af1aeedbd1905bd12a
---
M thirdparty/preflight.py
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/10304/1
--
To view, visit http://gerrit.cloudera.org:8080/10304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9bd33ab489d742e9cdfc9af1aeedbd1905bd12a
Gerrit-Change-Number: 10304
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] preflight: add checks for openssl and zlib
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10304 )
Change subject: preflight: add checks for openssl and zlib
......................................................................
preflight: add checks for openssl and zlib
The openssl devel package is required for Kudu, but also for squeasel, so
we should check for its existence in preflight.py.
Same goes for the zlib devel package, which is also required by IWYU.
Change-Id: Ib9bd33ab489d742e9cdfc9af1aeedbd1905bd12a
Reviewed-on: http://gerrit.cloudera.org:8080/10304
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M thirdparty/preflight.py
1 file changed, 23 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9bd33ab489d742e9cdfc9af1aeedbd1905bd12a
Gerrit-Change-Number: 10304
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] preflight: add checks for openssl and zlib
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10304 )
Change subject: preflight: add checks for openssl and zlib
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9bd33ab489d742e9cdfc9af1aeedbd1905bd12a
Gerrit-Change-Number: 10304
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 04 May 2018 15:15:32 +0000
Gerrit-HasComments: No
[kudu-CR] preflight: add checks for openssl and zlib
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10304 )
Change subject: preflight: add checks for openssl and zlib
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ib9bd33ab489d742e9cdfc9af1aeedbd1905bd12a
Gerrit-Change-Number: 10304
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] preflight: add checks for openssl and zlib
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10304 )
Change subject: preflight: add checks for openssl and zlib
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated failure.
--
To view, visit http://gerrit.cloudera.org:8080/10304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9bd33ab489d742e9cdfc9af1aeedbd1905bd12a
Gerrit-Change-Number: 10304
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 04 May 2018 03:35:50 +0000
Gerrit-HasComments: No