You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hughhhh (via GitHub)" <gi...@apache.org> on 2023/11/08 19:57:48 UTC
[PR] fix: always denorm column value before querying values [superset]
hughhhh opened a new pull request, #25919:
URL: https://github.com/apache/superset/pull/25919
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
currently with some databases/engines the `/<datasource_type>/<int:datasource_id>/column/<column_name>/values/` endpoint values due to malformatted queries. One of the edge cases has to do with column names not being denormalized. To fix this we'll denormalize the column name before querying for values
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always denorm column value before querying values [superset]
Posted by "jfrag1 (via GitHub)" <gi...@apache.org>.
jfrag1 commented on code in PR #25919:
URL: https://github.com/apache/superset/pull/25919#discussion_r1391482228
##########
superset/models/helpers.py:
##########
@@ -1341,36 +1341,34 @@ def get_time_filter( # pylint: disable=too-many-arguments
return and_(*l)
def values_for_column(self, column_name: str, limit: int = 10000) -> list[Any]:
- """Runs query against sqla to retrieve some
- sample values for the given column.
- """
- cols = {}
- for col in self.columns:
- if isinstance(col, dict):
- cols[col.get("column_name")] = col
- else:
- cols[col.column_name] = col
-
- target_col = cols[column_name]
- tp = None # todo(hughhhh): add back self.get_template_processor()
+ # always denormalize column name before querying for values
+ db_dialect = self.database.get_dialect()
+ denomalized_col_name = self.database.db_engine_spec.denormalize_name(
Review Comment:
nit: denomalized -> denormalized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always denorm column value before querying values [superset]
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh commented on code in PR #25919:
URL: https://github.com/apache/superset/pull/25919#discussion_r1388119105
##########
superset/models/helpers.py:
##########
@@ -1341,36 +1342,34 @@ def get_time_filter( # pylint: disable=too-many-arguments
return and_(*l)
def values_for_column(self, column_name: str, limit: int = 10000) -> list[Any]:
- """Runs query against sqla to retrieve some
- sample values for the given column.
- """
- cols = {}
- for col in self.columns:
- if isinstance(col, dict):
- cols[col.get("column_name")] = col
- else:
- cols[col.column_name] = col
-
- target_col = cols[column_name]
- tp = None # todo(hughhhh): add back self.get_template_processor()
+ # always denormalize column name before querying for values
+ db_dialect = self.database.get_dialect()
+ denomalized_col_name = self.database.db_engine_spec.denormalize_name(
Review Comment:
denomarlized name will return the original value if it can't be adjusted by the engine:
[preset-io/superset@60e1526/superset/db_engine_specs/base.py#L1950](https://github.com/preset-io/superset/blob/60e1526f6acc5cbfd126a29ac7d6af9420f8a648/superset/db_engine_specs/base.py#L1950)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always denorm column value before querying values [superset]
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on code in PR #25919:
URL: https://github.com/apache/superset/pull/25919#discussion_r1387193751
##########
superset/datasource/api.py:
##########
@@ -116,8 +116,14 @@ def get_column_values(
row_limit = apply_max_row_limit(app.config["FILTER_SELECT_ROW_LIMIT"])
try:
+ # always denormalize column name before querying for values
+ db_engine_spec = datasource.database.db_engine_spec
+ db_dialect = datasource.database.get_dialect()
+ denomalized_col_name = db_engine_spec.denormalize_name(
+ db_dialect, column_name
+ )
Review Comment:
It's better to move this logic to the `datasource.values_for_column` method, so that the API doesn't have any business logic, and so that calls to `datasource.values_for_column` from other places also work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always denorm column value before querying values [superset]
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh merged PR #25919:
URL: https://github.com/apache/superset/pull/25919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org