[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #145: Simplify PerformReleaseMojo

[GitBox <gi...@apache.org>]

nielsbasjes commented on code in PR #145:
URL: https://github.com/apache/maven-release/pull/145#discussion_r950903477


##########
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java:
##########
@@ -179,16 +139,6 @@ public void execute()
                 releaseDescriptor.setScmSourceUrl( connectionUrl );
             }
 
-            if ( username != null )
-            {
-                releaseDescriptor.setScmUsername( username );
-            }
-
-            if ( password != null )
-            {
-                releaseDescriptor.setScmPassword( password );
-            }
-

Review Comment:
   Sure this should be removed?
   There is no scenario when during the perform release the username/password are needed?
   If there is no such scenario: Why do you keep the scm source url?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org