[buildstream] branch tristan/source-api-kwargs created (now 16142f2)

[tv...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tvb pushed a change to branch tristan/source-api-kwargs
in repository https://gitbox.apache.org/repos/asf/buildstream.git.


      at 16142f2  source.py: Remove ambiguous kwargs from public API signature

This branch includes the following new commits:

     new 16142f2  source.py: Remove ambiguous kwargs from public API signature

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[buildstream] 01/01: source.py: Remove ambiguous kwargs from public API signature

[tv...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tvb pushed a commit to branch tristan/source-api-kwargs
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 16142f276a8898868949082d7db6ae625e7c6ca2
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Thu Sep 9 17:02:40 2021 +0900

    source.py: Remove ambiguous kwargs from public API signature
---
 src/buildstream/source.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/buildstream/source.py b/src/buildstream/source.py
index 01bc270..bd4b3ec 100644
--- a/src/buildstream/source.py
+++ b/src/buildstream/source.py
@@ -424,7 +424,7 @@ class Source(Plugin):
         """
         raise ImplError("Source plugin '{}' does not implement set_ref()".format(self.get_kind()))
 
-    def track(self, **kwargs) -> SourceRef:
+    def track(self, *, previous_sources_dir: str = None) -> SourceRef:
         """Resolve a new ref from the plugin's track option
 
         Args:
@@ -452,7 +452,7 @@ class Source(Plugin):
         # Allow a non implementation
         return None
 
-    def fetch(self, **kwargs) -> None:
+    def fetch(self, *, previous_sources_dir: str = None) -> None:
         """Fetch remote sources and mirror them locally, ensuring at least
         that the specific reference is cached locally.