You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "JangAyeon (via GitHub)" <gi...@apache.org> on 2026/09/28 04:40:45 UTC

[PR] [ZEPPELIN-6584] Fix reversed line diff direction in New UI revision comparator [zeppelin]

JangAyeon opened a new pull request, #5507:
URL: https://github.com/apache/zeppelin/pull/5507

   ### What is this PR for?
   The New UI revision comparator labels a comparison as `first --> second` (e.g. `older --> newer`), but `compareRevisions()` built the line-level diff from the second revision back to the first. As a result, added lines were rendered as red deletions and removed lines as green insertions for paragraphs present in both revisions.
   
   This PR computes the line diff in the same `first --> second` direction shown in the UI, matching the legacy AngularJS comparator (`diffLines(firstText, secondText)`). The whole-paragraph `added`/`deleted` classification, which was already correct, is unchanged.
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] - Fix line diff direction
   * [x] - Add focused comparator unit tests
   
   ### What is the Jira issue?
   [ZEPPELIN-6584](https://issues.apache.org/jira/browse/ZEPPELIN-6584)
   
   ### How should this be tested?
   * Unit tests:
   ```
     cd zeppelin-web-angular
     npm run test:shell -- revisions-comparator.component.spec.ts
     npm run lint
   ```
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6584] Fix reversed line diff direction in New UI revision comparator [zeppelin]

Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha merged PR #5507:
URL: https://github.com/apache/zeppelin/pull/5507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6584] Fix reversed line diff direction in New UI revision comparator [zeppelin]

Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha commented on PR #5507:
URL: https://github.com/apache/zeppelin/pull/5507#issuecomment-5914901926

   Merged into master (45f305a7).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org