You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/28 07:47:06 UTC

[GitHub] [skywalking] hanahmily commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL

hanahmily commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549248213



##########
File path: oap-server/server-bootstrap/src/main/resources/otel-oc-rules/istio-controlplane.yaml
##########
@@ -28,7 +28,7 @@
 #    "-P6H3M"    -- parses as "-6 hours and -3 minutes"
 #    "-P-6H+3M"  -- parses as "+6 hours and -3 minutes"
 # </pre>
-expSuffix: tag({tags -> tags.cluster = 'istio-ctrl::' + tags.cluster}).service(['cluster', 'app'])

Review comment:
       No, we should let the OT collector handle it by "relabel" as the OAP cluster is a center cluster that can't identify the metrics from which cluster. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org