You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2024/08/30 06:50:57 UTC
[PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
NihalJain opened a new pull request, #6184:
URL: https://github.com/apache/hbase/pull/6184
…ansitive dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2414874087
Rebased code as https://github.com/apache/hbase/pull/6258 is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1738056707
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -200,16 +200,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
-
- <!-- Adds junit libs to lib/test -->
Review Comment:
remove these as well, need to see if need to still keep?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1814778568
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just to dump it into
Review Comment:
This looks iffy and fragile.
What about adding a new module which is used only for generating cached-classpath instead ?
Or maybe using hbase-it, IF that already has all the dependencies we need for cached-classpath ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809276533
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -45,6 +45,8 @@
<dependencySets>
<dependencySet>
<excludes>
+ <exclude>org.apache.hadoop:*:test-jar</exclude>
Review Comment:
I had added this as a safety check AFAIR. But let me try again and come back to you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1799306713
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -200,16 +200,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
-
- <!-- Adds junit libs to lib/test -->
Review Comment:
Would be handled with comment https://github.com/apache/hbase/pull/6184/files#r1799303394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1804146366
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -45,6 +45,8 @@
<dependencySets>
<dependencySet>
<excludes>
+ <exclude>org.apache.hadoop:*:test-jar</exclude>
Review Comment:
Are those included without this exclusion, or is this just a safety measure ?
##########
bin/hbase:
##########
@@ -766,13 +777,17 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
+
+ if [[ "$CLASS" =~ .*IntegrationTest.* ]] || [[ "$CLASS" =~ .*Chaos.* ]]; then
for f in ${HBASE_HOME}/lib/test/*.jar; do
if [ -f "${f}" ]; then
CLASSPATH="${CLASSPATH}:${f}"
fi
done
+
+ add_jars_from_compiled_source
Review Comment:
Why is this needed ?
Aren't we adding the non-test jars already (before this patch) ?
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -33,7 +33,6 @@
<useAllReactorProjects>true</useAllReactorProjects>
<includes>
<!-- Keep this list sorted by name -->
- <include>org.apache.hbase:hbase-annotations</include>
Review Comment:
Interesting. I didn't know these are only used for tests.
##########
hbase-it/pom.xml:
##########
@@ -375,6 +375,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
I think we should leve these as compile scope.
hbase-it is dependend upon by several external projects, and having these in compile scope ensures that they will get the transitive dependencies without having to depend on them explicitly.
Now I'm not sure that depending on hbase-it is actually a good idea, external projects should probably depend on hbase-testing-util, and any other necessary hbase module explicitly, but even Phoenix depends on hbase-it.
##########
bin/hbase:
##########
@@ -766,13 +777,17 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
+
+ if [[ "$CLASS" =~ .*IntegrationTest.* ]] || [[ "$CLASS" =~ .*Chaos.* ]]; then
for f in ${HBASE_HOME}/lib/test/*.jar; do
if [ -f "${f}" ]; then
CLASSPATH="${CLASSPATH}:${f}"
fi
done
+
+ add_jars_from_compiled_source
Review Comment:
If this is for Junit, etc, then IMO we should still copy them to lib/test (just skip them when packaging the assemblies)
##########
hbase-thrift/pom.xml:
##########
@@ -444,6 +444,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
I think it's fine to keep this in one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1801878664
##########
hbase-assembly/pom.xml:
##########
@@ -47,14 +47,8 @@
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
- <!-- Intra-project dependencies -->
- <dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-it</artifactId>
- <type>test-jar</type>
- </dependency>
<!-- Hamcrest is required by hbase-it (via junit), but as long as we're grabbing the hbase-it test-jar,
- maven dependency resolution won't pick it up for us. -->
+ maven dependency resolution won't pick it up for us. -->
Review Comment:
undo this mistaken change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1801874051
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2427428726
Summary of 4th commit:
This commit addresses the review comments and improves the handling of how we can run IT, other tools in dev environment post this change. Now we revert back to directly using cached_classpath.txt to load jars required during runtime (as before).
NOTE: To ensures the content of cached_classpath.txt is same as without this patch (which was not the case until commit 3 as we were removing dependencies from hbase-assembly), we retain some jars (including test jars) in assembly pom.xml although we actually remove them during tarball creation.
Only 1 review comment is pending: on checking whether *:test-jar is a safety check or if we really hit it. I have forgotten what was the case given I rasied v1 of this PR almost 2 months ago. Let me redo analysis and come back to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1810973249
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just to dump in into
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2422479297
I'm not sure hbase-it needs to be reverted.
At first I thought that we shouldn't introduce this breaking change, but since this goes only into a new major version, maybe we should prioritize correctness over backwards compatibility.
Whatever you decide to with hbase-it is fine by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2416305464
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | docker | 0m 6s | | Docker failed to build run-specific yetus/hbase:tp-17799}. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/5/console |
| versions | git=2.25.1 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1799306224
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -162,15 +165,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
- <!-- Adds junit libs to lib/test -->
Review Comment:
Would be handled with comment https://github.com/apache/hbase/pull/6184/files#r1799303394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2415005363
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 28s | | master passed |
| +1 :green_heart: | compile | 8m 40s | | master passed |
| +1 :green_heart: | spotless | 0m 46s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 2s | | the patch passed |
| +1 :green_heart: | compile | 8m 10s | | the patch passed |
| +1 :green_heart: | javac | 8m 10s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 1s | | The patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38) |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | hadoopcheck | 11m 48s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 45s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 0s | | The patch does not generate ASF License warnings. |
| | | 46m 43s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile |
| uname | Linux 3aff35263531 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 46190f056f145c8ed1e250cd687d8afaffb7ea7e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 190 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/3/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1802747649
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -65,7 +62,10 @@
<unpack>false</unpack>
<dependencySets>
<dependencySet>
+ <useTransitiveFiltering>false</useTransitiveFiltering>
Review Comment:
Revert: This is not needed, just verified again.
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -44,7 +44,10 @@
<outputDirectory>lib</outputDirectory>
<dependencySets>
<dependencySet>
+ <useTransitiveFiltering>false</useTransitiveFiltering>
Review Comment:
Revert: This is not needed, just verified again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809281916
##########
hbase-it/pom.xml:
##########
@@ -375,6 +375,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
Yes we should force dependent projects to fix their dependencies. If we keep these they will leak a lot of test jars from hadoop.
##########
hbase-it/pom.xml:
##########
@@ -375,6 +375,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
Marking as resolved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2427505247
Updated Info:
1) List of jars removed with this patch from our assembly
```
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/mockito-core-4.11.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/junit-4.13.2.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/hamcrest-core-1.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-servlet-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-server-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/mssql-jdbc-6.2.1.jre7.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/leveldbjni-all-1.8.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/json-io-2.5.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jna-5.2.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-plus-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-jndi-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-annotations-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-client-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-server-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-client-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/java-util-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/HikariCP-java7-2.4.12.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-testing-util-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-hadoop-compat-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-web-proxy-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-timelineservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-tests-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-resourcemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-nodemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-registry-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minikdc-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minicluster-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-shuffle-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-hs-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-app-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-hdfs-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-common-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/geronimo-jcache_1.0_spec-1.0-alpha-1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/fst-2.50.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/ehcache-3.3.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/commons-csv-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-tree-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-commons-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-analysis-9.3.jar
```
and
```
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/mockito-core-4.11.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/junit-4.13.2.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/hamcrest-core-1.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/websocket-servlet-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/websocket-server-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/mssql-jdbc-6.2.1.jre7.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/leveldbjni-all-1.8.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/json-io-2.5.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jna-5.2.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-plus-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-jndi-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-annotations-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax.websocket-client-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax.websocket-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax-websocket-server-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax-websocket-client-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/java-util-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/HikariCP-java7-2.4.12.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-web-proxy-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-timelineservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-tests-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-resourcemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-nodemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-registry-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-minicluster-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-shuffle-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-jobclient-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-hs-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-app-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-common-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/geronimo-jcache_1.0_spec-1.0-alpha-1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/fst-2.50.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/ehcache-3.3.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/commons-csv-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-tree-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-commons-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-analysis-9.3.jar
```
2) Size Comparison, master vs master with this PR::
```
705528 -rw-r--r--@ 1 nihaljain user 361228649 Oct 16 02:11 assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
682160 -rw-r--r--@ 1 nihaljain user 349262475 Oct 16 02:11 assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
```
VS
```
629032 -rw-r--r--@ 1 nihaljain user 322063229 Oct 22 00:09 assembly_HBASE-28433_v2/hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
625944 -rw-r--r--@ 1 nihaljain user 320483247 Oct 22 00:09 assembly_HBASE-28433_v2/hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
```
3) Diff of cached paths: EMPTY
```
hbase % diff <( cat assembly_master/cached_classpath.txt | sed -e 's/:/\n/g' | sort) <( cat assembly_HBASE-28433_v2/cached_classpath.txt | sed -e 's/:/\n/g' | sort )
hbase %
```
4) Started hbase cluster in standalone mode and tested following:
- From extracted bin:
- Started shell and verified basic CRUD
- Triggered IntegrationTestsDriver: Fails as expected
- Ran tools from last round of refactoring, no new issues seen
- From compiled source bin:
- Started shell and verified basic CRUD
- Triggered IntegrationTestsDriver and no failure observed.
Please let me know if I should verify anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809277418
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -162,15 +165,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
- <!-- Adds junit libs to lib/test -->
Review Comment:
I have deleted these as we need them only in dev mode and for that we already are handling it via cached_classpath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2427920893
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 39s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 1s | | master passed |
| +1 :green_heart: | compile | 2m 7s | | master passed |
| +1 :green_heart: | javadoc | 3m 35s | | master passed |
| +1 :green_heart: | shadedjars | 5m 10s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 49s | | the patch passed |
| +1 :green_heart: | compile | 2m 7s | | the patch passed |
| +1 :green_heart: | javac | 2m 7s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 35s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 9s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 273m 14s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/6/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 310m 3s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 8e9120d3060d 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 555573c8f48895acd527b11df4782327162cd964 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/6/testReport/ |
| Max. process+thread count | 8762 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/6/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2337681529
Nice to see progress here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1764500194
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
Good point.
I would the option in the script, and make sure that ITs can be run from compiled source directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1764501743
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -162,15 +165,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
- <!-- Adds junit libs to lib/test -->
Review Comment:
We need to somehow make sure that the test jars are available when starting HBase from the source directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2414880498
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | docker | 0m 5s | | Docker failed to build run-specific yetus/hbase:tp-19244}. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/3/console |
| versions | git=2.25.1 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2415195017
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 4s | | master passed |
| +1 :green_heart: | compile | 8m 18s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 2s | | the patch passed |
| +1 :green_heart: | compile | 8m 15s | | the patch passed |
| +1 :green_heart: | javac | 8m 15s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 1s | | No new issues. |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | hadoopcheck | 11m 31s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 44s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 58s | | The patch does not generate ASF License warnings. |
| | | 45m 4s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile |
| uname | Linux fe3dfe8194cd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / bc7c28fb5497c6bf3c6a012b394f85b2246b86f6 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 188 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/4/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2431845929
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 47s | | master passed |
| +1 :green_heart: | compile | 12m 0s | | master passed |
| +1 :green_heart: | spotless | 1m 21s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 58s | | the patch passed |
| +1 :green_heart: | compile | 13m 33s | | the patch passed |
| +1 :green_heart: | javac | 13m 33s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 1s | | The patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38) |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | hadoopcheck | 15m 24s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 55s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 19s | | The patch does not generate ASF License warnings. |
| | | 65m 25s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile |
| uname | Linux d2008eb8b632 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c1cc762fe06ac2c325beab9135f77c8572ed7d67 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 187 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1799307109
##########
hbase-thrift/pom.xml:
##########
@@ -444,6 +444,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
Any thoughts? @stoty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1802015480
##########
hbase-thrift/pom.xml:
##########
@@ -444,6 +444,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
Now when I think again, seems it is better this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2416416780
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 1s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 1s | | master passed |
| +1 :green_heart: | compile | 8m 3s | | master passed |
| +1 :green_heart: | spotless | 0m 43s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 1s | | the patch passed |
| +1 :green_heart: | compile | 8m 1s | | the patch passed |
| +1 :green_heart: | javac | 8m 1s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 1s | | No new issues. |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | hadoopcheck | 11m 23s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 58s | | The patch does not generate ASF License warnings. |
| | | 44m 21s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile |
| uname | Linux 2805c3733ad5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 35bec8bb23384cea5202ae6d6c3d23baf46aad00 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 192 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/5/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2427415561
> I'm not sure hbase-it needs to be reverted anymore.
>
> At first I thought that we shouldn't introduce this potenitally breaking change, but since this goes only into a new major version, maybe we should prioritize correctness over backwards compatibility with incorrectly set up downstream projects.
>
> Whatever you decide to do with hbase-it is fine by me.
Went ahead with changing scope of the hadoop-minicluster jars from compile to test for correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2429754145
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 40s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 17s | | master passed |
| +1 :green_heart: | compile | 7m 54s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 57s | | the patch passed |
| +1 :green_heart: | compile | 7m 53s | | the patch passed |
| +1 :green_heart: | javac | 7m 53s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 1s | | The patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38) |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | hadoopcheck | 11m 31s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 58s | | The patch does not generate ASF License warnings. |
| | | 44m 44s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile |
| uname | Linux b252b1d49813 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c1cc762fe06ac2c325beab9135f77c8572ed7d67 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 188 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/7/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1738055304
##########
hbase-thrift/pom.xml:
##########
@@ -444,6 +444,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
During work for this PR, found that a lot of test jars were coming to our assembly as hadoop-minicluster was marked as compile scope. Thinking of doing this as another JIRA to keep PR simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2320257149
This will require HBASE-28433 to be inplace first. Putting this up to give a fair idea on how changes would look before I start on HBASE-28433. Also test failures of this PR would give a fair idea on what all should be moved in new module as we refactor as part of HBASE-28433.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2430302116
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 27s | | master passed |
| +1 :green_heart: | compile | 2m 23s | | master passed |
| +1 :green_heart: | javadoc | 3m 41s | | master passed |
| +1 :green_heart: | shadedjars | 5m 11s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 52s | | the patch passed |
| +1 :green_heart: | compile | 2m 5s | | the patch passed |
| +1 :green_heart: | javac | 2m 5s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 36s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 10s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 281m 32s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/7/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 319m 33s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 623776eba159 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c1cc762fe06ac2c325beab9135f77c8572ed7d67 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/7/testReport/ |
| Max. process+thread count | 8070 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/7/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1764502556
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -200,16 +200,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
-
- <!-- Adds junit libs to lib/test -->
Review Comment:
I would expect that ITs need them.
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -200,16 +200,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
-
- <!-- Adds junit libs to lib/test -->
Review Comment:
at least junit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1764500194
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
Good point.
I would the keep this code in the script, and make sure that ITs can be run from compiled source directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1738058267
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
should we be really be dropping this? how other will run IT if dropped? need to think more on this! may be create a subtask to handle/document how to run ITs once we remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1738058267
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
should we be really be dropping this? how other will run IT if dropped? need to think more on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2321031374
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 38s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 0s | | master passed |
| +1 :green_heart: | compile | 2m 11s | | master passed |
| +1 :green_heart: | javadoc | 3m 37s | | master passed |
| +1 :green_heart: | shadedjars | 5m 19s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 55s | | the patch passed |
| +1 :green_heart: | compile | 2m 5s | | the patch passed |
| +1 :green_heart: | javac | 2m 5s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 40s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 18s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 269m 4s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 304m 27s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 764cfe48390a 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8c81402f5ec284999a0fb21f7a284aa903b0ab21 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/1/testReport/ |
| Max. process+thread count | 5427 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1738058267
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
should we be really dropping this, need to think more on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2320282994
List of files deleted with this draft change:
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/test
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/hamcrest-core-1.3.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/junit-4.13.2.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/mockito-core-4.11.0.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-analysis-9.3.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-commons-9.3.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-tree-9.3.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/byte-buddy-agent-1.12.19.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/commons-csv-1.9.0.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/ehcache-3.3.1.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/fst-2.50.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/geronimo-jcache_1.0_spec-1.0-alpha-1.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-common-3.3.5-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-hdfs-3.3.5-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-app-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-common-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-hs-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-shuffle-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minicluster-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minikdc-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-registry-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-common-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-nodemanager-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-resourcemanager-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-tests-3.3.5-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-timelineservice-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-web-proxy-3.3.5.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-hadoop-compat-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-testing-util-4.0.0-alpha-1-SNAPSHOT.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/HikariCP-java7-2.4.12.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/java-util-1.9.0.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-client-impl-9.4.48.v20220622.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-server-impl-9.4.48.v20220622.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-api-1.0.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-client-api-1.0.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-annotations-9.4.48.v20220622.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-jndi-9.4.48.v20220622.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-plus-9.4.48.v20220622.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/jna-5.2.0.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/json-io-2.5.1.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/leveldbjni-all-1.8.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/mssql-jdbc-6.2.1.jre7.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/objenesis-3.3.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-server-9.4.48.v20220622.jar
- hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-servlet-9.4.48.v20220622.jar
Tarball size before: 371.2M
Tarball size after: 331.5M
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2320286386
UT failures will say if we are being too aggressive here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1799303394
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
Okay so basic we want to retain the 3 files under HBASE_HOME/lib/test i.e.
- hamcrest-core-1.3.jar
- junit-4.13.2.jar
- mockito-core-4.11.0.jar
Let me make this change and figure out if we can still run IT by building from source.
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
Okay so basically we want to retain the 3 files under HBASE_HOME/lib/test i.e.
- hamcrest-core-1.3.jar
- junit-4.13.2.jar
- mockito-core-4.11.0.jar
Let me make this change and figure out if we can still run IT by building from source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2415130807
Diff of directories with master vs master with this PR:
```
hbase % diff -rq assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/LICENSE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/LICENSE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/NOTICE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/NOTICE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/bin/hbase and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/bin/hbase differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/master/WEB-INF/web.xml and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/master/WEB-INF/web.xml differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/regionserver/WEB-INF/web.xml and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/regionserver/WEB-INF/web.xml differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/thrift/WEB-INF/web.xml and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/thrift/WEB-INF/web.xml differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/include/utils/version.h and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/include/utils/version.h differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: HikariCP-java7-2.4.12.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: asm-analysis-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: asm-commons-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: asm-tree-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: commons-csv-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: ehcache-3.3.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: fst-2.50.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: geronimo-jcache_1.0_spec-1.0-alpha-1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-common-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-hdfs-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-app-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-hs-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-jobclient-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-jobclient-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-shuffle-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-minicluster-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-minikdc-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-registry-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-nodemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-resourcemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-tests-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-timelineservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-web-proxy-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-annotations-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-annotations-4.0.0-alpha-1-SNAPSHOT.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-endpoint-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-endpoint-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-hadoop-compat-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-it-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-it-4.0.0-alpha-1-SNAPSHOT.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-testing-util-4.0.0-alpha-1-SNAPSHOT.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: java-util-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax-websocket-client-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax-websocket-server-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax.websocket-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax.websocket-client-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jetty-annotations-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jetty-jndi-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jetty-plus-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jna-5.2.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: json-io-2.5.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: leveldbjni-all-1.8.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: mssql-jdbc-6.2.1.jre7.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: websocket-server-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: websocket-servlet-9.4.48.v20220622.jar
hbase %
```
and
```
hbase % diff -rq assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/LICENSE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/LICENSE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/NOTICE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/NOTICE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/bin/hbase and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/bin/hbase differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: HikariCP-java7-2.4.12.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: asm-analysis-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: asm-commons-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: asm-tree-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: commons-csv-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: ehcache-3.3.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: fst-2.50.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: geronimo-jcache_1.0_spec-1.0-alpha-1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-common-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-app-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-hs-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-jobclient-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-shuffle-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-minicluster-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-registry-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-nodemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-resourcemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-tests-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-timelineservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-web-proxy-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: java-util-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax-websocket-client-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax-websocket-server-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax.websocket-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax.websocket-client-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jetty-annotations-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jetty-jndi-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jetty-plus-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jna-5.2.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: json-io-2.5.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: leveldbjni-all-1.8.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: mssql-jdbc-6.2.1.jre7.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: websocket-server-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: websocket-servlet-9.4.48.v20220622.jar
hbase %
```
----
Size Comparison:
```
assembly_master:
total 1387688
705528 -rw-r--r--@ 1 nihaljain user 361228649 Oct 16 02:11 hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
682160 -rw-r--r--@ 1 nihaljain user 349262475 Oct 16 02:11 hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
assembly_HBASE-28433:
total 1258728
630912 -rw-r--r--@ 1 nihaljain user 323023191 Oct 16 02:03 hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
627816 -rw-r--r--@ 1 nihaljain user 321441419 Oct 16 02:03 hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809279964
##########
hbase-thrift/pom.xml:
##########
@@ -444,6 +444,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
Marking as resolved!
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -200,16 +200,6 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
-
- <!-- Adds junit libs to lib/test -->
Review Comment:
Marking as resolved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809275585
##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
else
CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then
Review Comment:
This code is no longer needed as we get these jars via cached_classpath.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809320827
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -45,6 +45,8 @@
<dependencySets>
<dependencySet>
<excludes>
+ <exclude>org.apache.hadoop:*:test-jar</exclude>
Review Comment:
We don't really hit this, just a safety check then.
```
[INFO] --- assembly:3.2.0:single (default-cli) @ hbase-assembly ---
[WARNING] Parameter 'finalName' is read-only, must not be used in configuration
[INFO] Reading assembly descriptor: src/main/assembly/hadoop-three-compat.xml
[INFO] Reading assembly descriptor: src/main/assembly/client.xml
[WARNING] The following patterns were never triggered in this artifact exclusion filter:
o 'org.apache.hadoop:*:test-jar'
o 'org.apache.hbase:*:test-jar'
o 'log4j:log4j'
o 'org.apache.htrace:htrace-core4'
o 'org.apache.htrace:htrace-core'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2427545302
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 37s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 37s | | master passed |
| +1 :green_heart: | compile | 11m 39s | | master passed |
| +1 :green_heart: | spotless | 1m 3s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 8s | | the patch passed |
| +1 :green_heart: | compile | 13m 8s | | the patch passed |
| +1 :green_heart: | javac | 13m 8s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 2s | | The patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38) |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | hadoopcheck | 17m 1s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 5s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 27s | | The patch does not generate ASF License warnings. |
| | | 67m 15s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile |
| uname | Linux a02c1c692f08 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 555573c8f48895acd527b11df4782327162cd964 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 189 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/6/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2320385861
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 11s | | master passed |
| +1 :green_heart: | compile | 7m 52s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 59s | | the patch passed |
| +1 :green_heart: | compile | 7m 49s | | the patch passed |
| +1 :green_heart: | javac | 7m 49s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 0s | | The patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38) |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | hadoopcheck | 11m 30s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 57s | | The patch does not generate ASF License warnings. |
| | | 44m 13s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile |
| uname | Linux c151f793dc07 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8c81402f5ec284999a0fb21f7a284aa903b0ab21 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 190 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/1/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2411167323
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 16s | | master passed |
| +1 :green_heart: | compile | 8m 12s | | master passed |
| +1 :green_heart: | checkstyle | 1m 13s | | master passed |
| +1 :green_heart: | spotbugs | 14m 28s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 2m 5s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 4s | | the patch passed |
| +1 :green_heart: | compile | 8m 6s | | the patch passed |
| -0 :warning: | javac | 8m 6s | [/results-compile-javac-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/2/artifact/yetus-general-check/output/results-compile-javac-root.txt) | root generated 66 new + 1211 unchanged - 4 fixed = 1277 total (was 1215) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 11s | [/results-checkstyle-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/2/artifact/yetus-general-check/output/results-checkstyle-root.txt) | root: The patch generated 46 new + 66 unchanged - 39 fixed = 112 total (was 105) |
| +1 :green_heart: | shellcheck | 0m 0s | | The patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38) |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| -1 :x: | spotbugs | 1m 41s | [/new-spotbugs-hbase-server.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html) | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | spotbugs | 7m 41s | [/new-spotbugs-root.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/2/artifact/yetus-general-check/output/new-spotbugs-root.html) | root generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0) |
| +1 :green_heart: | hadoopcheck | 11m 42s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 57s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 2m 36s | | The patch does not generate ASF License warnings. |
| | | 83m 43s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-server |
| | Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:[line 111] |
| SpotBugs | module:root |
| | Integral division result cast to double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:[line 3154] |
| | org.apache.hadoop.hbase.PerformanceEvaluation$RunResult defines compareTo(PerformanceEvaluation$RunResult) and uses Object.equals() At PerformanceEvaluation.java:Object.equals() At PerformanceEvaluation.java:[line 250] |
| | Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:[line 111] |
| | org.apache.hadoop.hbase.util.LoadTestTool.DEFAULT_NUM_REGIONS_PER_SERVER isn't final but should be At LoadTestTool.java:be At LoadTestTool.java:[line 167] |
| | org.apache.hadoop.hbase.util.MultiThreadedAction.verifyResultAgainstDataGenerator(Result, boolean, boolean) concatenates strings using + in a loop At MultiThreadedAction.java:using + in a loop At MultiThreadedAction.java:[line 415] |
| | Integral division result cast to double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:[line 206] |
| | org.apache.hadoop.hbase.util.MultiThreadedReader$HBaseReaderThread.createGet(long) concatenates strings using + in a loop At MultiThreadedReader.java:in a loop At MultiThreadedReader.java:[line 318] |
| | Dead store to rowKey in org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:[line 91] |
| | Inconsistent synchronization of org.apache.hadoop.hbase.util.MultiThreadedUpdater.writer; locked 75% of time Unsynchronized access at MultiThreadedUpdater.java:75% of time Unsynchronized access at MultiThreadedUpdater.java:[line 80] |
| | Unwritten field:MultiThreadedUpdaterWithACL.java:[line 94] |
| | Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At WALPerformanceEvaluation.java:is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At WALPerformanceEvaluation.java:[line 244] |
| | Format string should use %n rather than n in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At WALPerformanceEvaluation.java:rather than n in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At WALPerformanceEvaluation.java:[line 414] |
| | Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At WALPerformanceEvaluation.java:is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At WALPerformanceEvaluation.java:[line 171] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile spotbugs checkstyle hbaseanti |
| uname | Linux ab0ab581738c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / adb7158d9529a55ed38947d85cb92ecaf59f1577 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 193 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-balancer hbase-asyncfs hbase-server hbase-mapreduce hbase-diagnostics hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-examples . hbase-assembly hbase-it U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2410925891
Rebased code on top of #6258 to unblock progress here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2415021079
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | docker | 0m 5s | | Docker failed to build run-specific yetus/hbase:tp-29253}. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/4/console |
| versions | git=2.25.1 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1831036039
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just to dump it into
Review Comment:
Sorry lost momentum here.
> What about adding a new module which is used only for generating cached-classpath instead ?
Or maybe using hbase-it, IF that already has all the dependencies we need for cached-classpath ?
I could try generating cached-classpath for hbase-it, only thing is with current change we are able to ensure there is no cached-classpath change for code run via source directory even after this PR. Adding a new module just for cached-classpath sounds an overkill and will have issues with keeping pom.xml in sync.
But is not assembly's pom.xml for the same purpose? I mean I am not sure if current change is a hack since we maintain jars in assembly's pom.xml for generating classpath. For example we already have:
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809279037
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -33,7 +33,6 @@
<useAllReactorProjects>true</useAllReactorProjects>
<includes>
<!-- Keep this list sorted by name -->
- <include>org.apache.hbase:hbase-annotations</include>
Review Comment:
So did I. Only, during analysis for raising this I realised this module just has just test code, no main code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #6184:
URL: https://github.com/apache/hbase/pull/6184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2415140265
> 💔 **-1 overall**
>
> Vote Subsystem Runtime Logfile Comment
> +0 🆗 reexec 0m 0s Docker mode activated.
> -1 ❌ docker 0m 5s Docker failed to build run-specific yetus/hbase:tp-29253}.
> Subsystem Report/Notes
> GITHUB PR #6184
> Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/4/console
> versions git=2.25.1
> Powered by Apache Yetus 0.15.0 https://yetus.apache.org
> This message was automatically generated.
Not sure what is this failure 😕
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1804169498
##########
hbase-it/pom.xml:
##########
@@ -375,6 +375,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
Or we could just leave it like this, since they are going to have to make changes for HBase 3.0 anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1804169835
##########
hbase-it/pom.xml:
##########
@@ -375,6 +375,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
and force them to fix their test dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2410956658
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | docker | 0m 6s | | Docker failed to build run-specific yetus/hbase:tp-18676}. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/2/console |
| versions | git=2.25.1 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1738076334
##########
bin/hbase:
##########
@@ -340,6 +340,7 @@ fi
#If configured and available, add Hadoop to the CLASSPATH and to the JAVA_LIBRARY_PATH
if [ -n "${HADOOP_IN_PATH}" ] && [ -f "${HADOOP_IN_PATH}" ]; then
+ # TODO: Drop/Modify this logic
Review Comment:
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2422243352
Thank you @stoty for reviewing the code, will have a look at comments and revert back soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809472143
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just to dump in into
Review Comment:
typo in -> it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809280292
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -33,7 +33,6 @@
<useAllReactorProjects>true</useAllReactorProjects>
<includes>
<!-- Keep this list sorted by name -->
- <include>org.apache.hbase:hbase-annotations</include>
Review Comment:
Marking as resolved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1832179812
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just to dump it into
Review Comment:
I still don't like it, but I checked that we explictly list the dependencies to be included in the descriptors, so this is unlikely to cause regressions.
I'm going to work on the assemblies in the next sub-task anyway, I will check if can find a more elegant solution then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1831036039
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just to dump it into
Review Comment:
Sorry lost momentum here.
> What about adding a new module which is used only for generating cached-classpath instead ?
Or maybe using hbase-it, IF that already has all the dependencies we need for cached-classpath ?
I could try generating cached-classpath for hbase-it, only thing is with current change we are able to ensure there is no cached-classpath change for code run via source directory even after this PR.
Adding a new module just for cached-classpath sounds an overkill and will have issues with keeping pom.xml in sync.
But is not assembly's pom.xml for the same purpose? I mean I am not sure if current change is a hack since we maintain jars in assembly's pom.xml for generating classpath. For example we already have:
```
<!-- To dump tools in hbase-procedure into cached_classpath.txt. -->
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-procedure</artifactId>
</dependency>
```
Assembly is anyways controlled via the *.xml's!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2461983643
Thank you so much @stoty for patiently reviewing this one. I will be merging this in next few hours, unless no new reviews/objections comes up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1802015480
##########
hbase-thrift/pom.xml:
##########
@@ -444,6 +444,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
Review Comment:
Now when I think again, seems it is better this way i.e. within this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28433 Modify the assembly to not include test jars and their tr… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2432758805
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 40s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 51s | | master passed |
| +1 :green_heart: | compile | 2m 6s | | master passed |
| +1 :green_heart: | javadoc | 3m 36s | | master passed |
| +1 :green_heart: | shadedjars | 5m 11s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 50s | | the patch passed |
| +1 :green_heart: | compile | 2m 5s | | the patch passed |
| +1 :green_heart: | javac | 2m 5s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 33s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 8s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 300m 2s | | root in the patch passed. |
| | | 336m 54s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6184 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 3d3f35b923b6 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c1cc762fe06ac2c325beab9135f77c8572ed7d67 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/testReport/ |
| Max. process+thread count | 8677 (vs. ulimit of 30000) |
| modules | C: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org