[GitHub] [spark] MaxGekk commented on pull request #37636: [SPARK-40156][SQL] url_decode() should the return an ERROR_CLASS

[GitBox <gi...@apache.org>]

MaxGekk commented on PR #37636:
URL: https://github.com/apache/spark/pull/37636#issuecomment-1227279545

   The test failure:
   ```
   [info] - url-functions.sql *** FAILED *** (315 milliseconds)
   [info]   url-functions.sql
   [info]   Expected "struct<[url_decode(http%3A%2F%2spark.apache.org):string]>", but got "struct<[]>" Schema did not match for query #12
   [info]   select url_decode('http%3A%2F%2spark.apache.org'): -- !query
   [info]   select url_decode('http%3A%2F%2spark.apache.org')
   [info]   -- !query schema
   [info]   struct<>
   [info]   -- !query output
   [info]   org.apache.spark.SparkIllegalArgumentException
   [info]   {
   [info]     "errorClass" : "CANNOT_DECODE_URL",
   [info]     "sqlState" : "42000",
   [info]     "messageParameters" : {
   [info]       "url" : "http%3A%2F%2spark.apache.org",
   [info]       "details" : "URLDecoder: Illegal hex characters in escape (%) pattern - For input string: \"2s\""
   [info]     }
   [info]   } (SQLQueryTestSuite.scala:472)
   ```
   is related to your changes. Please, regenerate the golden file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org