[jira] [Comment Edited] (BEAM-3296) Combine semantics for empty bundle for min, max is wrong

["Gary (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685211#comment-16685211 ] 

Gary edited comment on BEAM-3296 at 11/13/18 1:41 PM:
------------------------------------------------------

I could be doing this wrong, but I'm observing slightly different behavior than the behavior described above.

debug.Printf(s, "Sum: %v", stats.Sum(s, emptyPCollection))

Expected output: {{Sum: 0}}
 Actual output: (nothing)

The expected output is a PCollection with a single element in it with the default value for the type (0).
 The observed behavior is an empty PCollection.  

 


was (Author: belvin):
I could be doing this wrong, but I'm observing slightly different behavior than the behavior described above.

{{ debug.Printf(s, "Sum: %v", stats.Sum(s, emptyPCollection))}}

Expected output: {{Sum: 0}}
 Actual output: (nothing)

The expected output is a PCollection with a single element in it with the default value for the type (0).
The observed behavior is an empty PCollection.  

 

> Combine semantics for empty bundle for min, max is wrong
> --------------------------------------------------------
>
>                 Key: BEAM-3296
>                 URL: https://issues.apache.org/jira/browse/BEAM-3296
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Priority: Minor
>
> The combine semantics for Min for empty bundles is to emit MAX_INT, if using global windows. Our implementation currently deviates from java, because we use binary combiners (and thus emit the default element for the type (0).
> Ditto for the other binary combiners in stats.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)